Mirrors/linkding
1
0
Fork 0
mirror of https://github.com/sissbruecker/linkding.git synced 2026-02-28 06:53:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Turn scheme-less URLs into HTTPS instead of HTTP links (#1225)

Browse Source 
* Turn scheme-less URLs into HTTPS instead of HTTP links

Signed-off-by: Max Kunzelmann <maxdev@posteo.de>

* fix bug, add tests

* use single linker instance

* simplify logic

* lint

---------

Signed-off-by: Max Kunzelmann <maxdev@posteo.de>
Co-authored-by: Sascha Ißbrücker <sascha.issbruecker@gmail.com>
This commit is contained in:
Max
2026-01-05 16:45:33 +01:00
committed by GitHub
parent afbf85b249
commit cbc8618805
2 changed files with 54 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
bookmarks/tests/test_bookmarks_list_template.py
View File

@@ -919,6 +919,42 @@ class BookmarkListTemplateTest(TestCase, BookmarkFactoryMixin, HtmlTestMixin):
note_html = '<p><a href="https://example.com" rel="nofollow">https://example.com</a></p>'
self.assertNotes(html, note_html, 1)
def test_note_linkify_converts_schemeless_urls_to_https(self):
# Scheme-less URL should become HTTPS
self.setup_bookmark(notes="Example: example.com")
html = self.render_template()
note_html = '<p>Example: <a href="https://example.com" rel="nofollow">example.com</a></p>'
self.assertNotes(html, note_html, 1)
# Explicit http:// should stay as http://
self.setup_bookmark(notes="Example: http://example.com")
html = self.render_template()
note_html = '<p>Example: <a href="http://example.com" rel="nofollow">http://example.com</a></p>'
self.assertNotes(html, note_html, 1)
# Explicit https:// should stay as https://
self.setup_bookmark(notes="Example: https://example.com")
html = self.render_template()
note_html = '<p>Example: <a href="https://example.com" rel="nofollow">https://example.com</a></p>'
self.assertNotes(html, note_html, 1)
# Email addresses should not be affected
self.setup_bookmark(notes="Contact: hello@example.com")
html = self.render_template()
note_html = "<p>Contact: hello@example.com</p>"
self.assertNotes(html, note_html, 1)
# ftp:// should not be converted to https
self.setup_bookmark(notes="FTP: ftp://ftp.example.com")
html = self.render_template()
note_html = '<p>FTP: <a href="ftp://ftp.example.com" rel="nofollow">ftp://ftp.example.com</a></p>'
self.assertNotes(html, note_html, 1)
def test_note_cleans_html(self):
self.setup_bookmark(notes='<script>alert("test")</script>')
self.setup_bookmark(