From 00cac4ba720c641f0f817b4fbf4228d9b74c61e8 Mon Sep 17 00:00:00 2001
From: Alejandro Celaya <alejandro@alejandrocelaya.com>
Date: Fri, 8 May 2020 11:48:31 +0200
Subject: [PATCH] Created rest test for list tags action

---
 .../Shlinkio.Shlink.Core.Entity.ShortUrl.php  |  1 +
 .../test-api/Action/ListTagsActionTest.php    | 50 +++++++++++++++++++
 module/Rest/test-api/Fixtures/TagsFixture.php |  1 +
 phpstan.neon                                  |  1 +
 4 files changed, 53 insertions(+)
 create mode 100644 module/Rest/test-api/Action/ListTagsActionTest.php

diff --git a/module/Core/config/entities-mappings/Shlinkio.Shlink.Core.Entity.ShortUrl.php b/module/Core/config/entities-mappings/Shlinkio.Shlink.Core.Entity.ShortUrl.php
index a4aef29f..871ac113 100644
--- a/module/Core/config/entities-mappings/Shlinkio.Shlink.Core.Entity.ShortUrl.php
+++ b/module/Core/config/entities-mappings/Shlinkio.Shlink.Core.Entity.ShortUrl.php
@@ -60,6 +60,7 @@ return static function (ClassMetadata $metadata, array $emConfig): void {
             ->setJoinTable(determineTableName('short_urls_in_tags', $emConfig))
             ->addInverseJoinColumn('tag_id', 'id', true, false, 'CASCADE')
             ->addJoinColumn('short_url_id', 'id', true, false, 'CASCADE')
+            ->setOrderBy(['name' => 'ASC'])
             ->build();
 
     $builder->createManyToOne('domain', Entity\Domain::class)
diff --git a/module/Rest/test-api/Action/ListTagsActionTest.php b/module/Rest/test-api/Action/ListTagsActionTest.php
new file mode 100644
index 00000000..0690d4f2
--- /dev/null
+++ b/module/Rest/test-api/Action/ListTagsActionTest.php
@@ -0,0 +1,50 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ShlinkioApiTest\Shlink\Rest\Action;
+
+use GuzzleHttp\RequestOptions;
+use Shlinkio\Shlink\TestUtils\ApiTest\ApiTestCase;
+
+class ListTagsActionTest extends ApiTestCase
+{
+    /**
+     * @test
+     * @dataProvider provideQueries
+     */
+    public function expectedListOfTagsIsReturned(array $query, array $expectedTags): void
+    {
+        $resp = $this->callApiWithKey(self::METHOD_GET, '/tags', [RequestOptions::QUERY => $query]);
+        $payload = $this->getJsonResponsePayload($resp);
+
+        $this->assertEquals(['tags' => $expectedTags], $payload);
+    }
+
+    public function provideQueries(): iterable
+    {
+        yield 'stats not requested' => [[], [
+            'data' => ['bar', 'baz', 'foo'],
+        ]];
+        yield 'stats requested' => [['withStats' => 'true'], [
+            'data' => ['bar', 'baz', 'foo'],
+            'stats' => [
+                [
+                    'tag' => 'bar',
+                    'shortUrlsCount' => 1,
+                    'visitsCount' => 2,
+                ],
+                [
+                    'tag' => 'baz',
+                    'shortUrlsCount' => 0,
+                    'visitsCount' => 0,
+                ],
+                [
+                    'tag' => 'foo',
+                    'shortUrlsCount' => 2,
+                    'visitsCount' => 5,
+                ],
+            ],
+        ]];
+    }
+}
diff --git a/module/Rest/test-api/Fixtures/TagsFixture.php b/module/Rest/test-api/Fixtures/TagsFixture.php
index 5bd10ca7..5d3333cc 100644
--- a/module/Rest/test-api/Fixtures/TagsFixture.php
+++ b/module/Rest/test-api/Fixtures/TagsFixture.php
@@ -24,6 +24,7 @@ class TagsFixture extends AbstractFixture implements DependentFixtureInterface
         $manager->persist($fooTag);
         $barTag = new Tag('bar');
         $manager->persist($barTag);
+        $manager->persist(new Tag('baz'));
 
         /** @var ShortUrl $abcShortUrl */
         $abcShortUrl = $this->getReference('abc123_short_url');
diff --git a/phpstan.neon b/phpstan.neon
index d983a985..e065acef 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -4,3 +4,4 @@ parameters:
 	ignoreErrors:
 		- '#AbstractQuery::setParameters()#'
 		- '#mustRun()#'
+		- '#AssociationBuilder::setOrderBy#'