Fix error when setting max results in a delete query

This commit is contained in:
Alejandro Celaya
2025-12-20 13:22:44 +01:00
parent 7712f790e5
commit 0ad777b6fa
9 changed files with 28 additions and 72 deletions

View File

@@ -19,9 +19,7 @@ readonly class ShortUrlRedirectRuleService implements ShortUrlRedirectRuleServic
{
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function rulesForShortUrl(ShortUrl $shortUrl): array
{
return $this->em->getRepository(ShortUrlRedirectRule::class)->findBy(
@@ -30,9 +28,7 @@ readonly class ShortUrlRedirectRuleService implements ShortUrlRedirectRuleServic
);
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function setRulesForShortUrl(ShortUrl $shortUrl, RedirectRulesData $data): array
{
$rules = [];
@@ -54,9 +50,7 @@ readonly class ShortUrlRedirectRuleService implements ShortUrlRedirectRuleServic
return $rules;
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function saveRulesForShortUrl(ShortUrl $shortUrl, array $rules): void
{
$normalizedAndDetachedRules = map($rules, function (ShortUrlRedirectRule $rule, int|string|float $priority) {

View File

@@ -12,9 +12,7 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
class ShortUrlsListFiltering extends ShortUrlsCountFiltering
{
/**
* @inheritDoc
*/
/** @inheritDoc */
public function __construct(
public readonly int|null $limit = null,
public readonly int|null $offset = null,

View File

@@ -16,9 +16,7 @@ use function sprintf;
/** @extends EntitySpecificationRepository<ShortUrl> */
class ExpiredShortUrlsRepository extends EntitySpecificationRepository implements ExpiredShortUrlsRepositoryInterface
{
/**
* @inheritDoc
*/
/** @inheritDoc */
public function delete(ExpiredShortUrlsConditions $conditions): int
{
$qb = $this->getEntityManager()->createQueryBuilder();
@@ -27,9 +25,7 @@ class ExpiredShortUrlsRepository extends EntitySpecificationRepository implement
return $this->applyConditions($qb, $conditions, fn () => (int) $qb->getQuery()->execute());
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function dryCount(ExpiredShortUrlsConditions $conditions): int
{
$qb = $this->getEntityManager()->createQueryBuilder();

View File

@@ -19,9 +19,7 @@ readonly class ShortUrlListService implements ShortUrlListServiceInterface
) {
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function listShortUrls(ShortUrlsParams $params, ApiKey|null $apiKey = null): Paginator
{
$defaultDomain = $this->urlShortenerOptions->defaultDomain;

View File

@@ -24,17 +24,13 @@ readonly class TagService implements TagServiceInterface
{
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function listTags(TagsParams $params, ApiKey|null $apiKey = null): Paginator
{
return $this->createPaginator(new TagsPaginatorAdapter($this->repo, $params, $apiKey), $params);
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function tagsInfo(TagsParams $params, ApiKey|null $apiKey = null): Paginator
{
return $this->createPaginator(new TagsInfoPaginatorAdapter($this->repo, $params, $apiKey), $params);
@@ -54,9 +50,7 @@ readonly class TagService implements TagServiceInterface
return $paginator;
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function deleteTags(array $tagNames, ApiKey|null $apiKey = null): void
{
if (ApiKey::isShortUrlRestricted($apiKey)) {
@@ -66,9 +60,7 @@ readonly class TagService implements TagServiceInterface
$this->repo->deleteByName($tagNames);
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function renameTag(Renaming $renaming, ApiKey|null $apiKey = null): Tag
{
if (ApiKey::isShortUrlRestricted($apiKey)) {

View File

@@ -64,9 +64,7 @@ readonly class VisitsStatsHelper implements VisitsStatsHelperInterface
);
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function visitsForShortUrl(
ShortUrlIdentifier $identifier,
VisitsParams $params,
@@ -87,9 +85,7 @@ readonly class VisitsStatsHelper implements VisitsStatsHelperInterface
);
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function visitsForTag(string $tag, WithDomainVisitsParams $params, ApiKey|null $apiKey = null): Paginator
{
/** @var TagRepository $tagRepo */
@@ -104,9 +100,7 @@ readonly class VisitsStatsHelper implements VisitsStatsHelperInterface
return $this->createPaginator(new TagVisitsPaginatorAdapter($repo, $tag, $params, $apiKey), $params);
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function visitsForDomain(string $domain, VisitsParams $params, ApiKey|null $apiKey = null): Paginator
{
/** @var DomainRepository $domainRepo */
@@ -121,9 +115,7 @@ readonly class VisitsStatsHelper implements VisitsStatsHelperInterface
return $this->createPaginator(new DomainVisitsPaginatorAdapter($repo, $domain, $params, $apiKey), $params);
}
/**
* @inheritDoc
*/
/** @inheritDoc */
public function orphanVisits(OrphanVisitsParams $params, ApiKey|null $apiKey = null): Paginator
{
/** @var VisitRepository $repo */