From 0f51b5b1ce98438e50c9dabd9fa341920def0298 Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Thu, 26 Aug 2021 09:52:11 +0200 Subject: [PATCH] Fixed warning displayed when trying to late visits and there are no pending --- module/Core/src/Repository/VisitRepository.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/module/Core/src/Repository/VisitRepository.php b/module/Core/src/Repository/VisitRepository.php index 1e157757..0fe539af 100644 --- a/module/Core/src/Repository/VisitRepository.php +++ b/module/Core/src/Repository/VisitRepository.php @@ -70,15 +70,17 @@ class VisitRepository extends EntitySpecificationRepository implements VisitRepo $qb = (clone $originalQueryBuilder)->andWhere($qb->expr()->gt('v.id', $lastId)); $iterator = $qb->getQuery()->toIterable(); $resultsFound = false; + /** @var Visit|null $lastProcessedVisit */ + $lastProcessedVisit = null; foreach ($iterator as $key => $visit) { $resultsFound = true; + $lastProcessedVisit = $visit; yield $key => $visit; } // As the query is ordered by ID, we can take the last one every time in order to exclude the whole list - /** @var Visit|null $visit */ - $lastId = $visit?->getId() ?? $lastId; + $lastId = $lastProcessedVisit?->getId() ?? $lastId; } while ($resultsFound); }