Mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2026-03-12 01:54:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improved PreviewGenerator by composing an ImageBuilder that creates new Image objects fore each URL

Browse Source
This commit is contained in:
Alejandro Celaya
2016-08-18 12:21:26 +02:00
parent 15247e832e
commit 2c91ded514
12 changed files with 181 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
module/Common/test/Service/PreviewGeneratorTest.php
View File

@@ -6,7 +6,9 @@ use mikehaertl\wkhtmlto\Image;
use PHPUnit_Framework_TestCase as TestCase;
use Prophecy\Argument;
use Prophecy\Prophecy\ObjectProphecy;
use Shlinkio\Shlink\Common\Image\ImageBuilder;
use Shlinkio\Shlink\Common\Service\PreviewGenerator;
use Zend\ServiceManager\ServiceManager;
class PreviewGeneratorTest extends TestCase
{
@@ -27,7 +29,13 @@ class PreviewGeneratorTest extends TestCase
{
$this->image = $this->prophesize(Image::class);
$this->cache = new ArrayCache();
$this->generator = new PreviewGenerator($this->image->reveal(), $this->cache, 'dir');
$this->generator = new PreviewGenerator(new ImageBuilder(new ServiceManager(), [
'factories' => [
Image::class => function () {
return $this->image->reveal();
},
]
]), $this->cache, 'dir');
}
/**
@@ -50,7 +58,6 @@ class PreviewGeneratorTest extends TestCase
$cacheId = sprintf('preview_%s.png', urlencode($url));
$expectedPath = 'dir/' . $cacheId;
$this->image->setPage($url)->shouldBeCalledTimes(1);
$this->image->saveAs($expectedPath)->shouldBeCalledTimes(1);
$this->image->getError()->willReturn('')->shouldBeCalledTimes(1);
@@ -69,7 +76,6 @@ class PreviewGeneratorTest extends TestCase
$cacheId = sprintf('preview_%s.png', urlencode($url));
$expectedPath = 'dir/' . $cacheId;
$this->image->setPage($url)->shouldBeCalledTimes(1);
$this->image->saveAs($expectedPath)->shouldBeCalledTimes(1);
$this->image->getError()->willReturn('Error!!')->shouldBeCalledTimes(1);