From 35147fecb29a0602a6d39c61181a16c78e9afe94 Mon Sep 17 00:00:00 2001
From: Alejandro Celaya <alejandro@alejandrocelaya.com>
Date: Sun, 3 Jul 2016 09:14:27 +0200
Subject: [PATCH 1/2] Replaced cli execution using expressive middleware by
 symfony/console

---
 bin/cli                                      | 17 ++--
 composer.json                                |  3 +-
 config/autoload/services.global.php          |  4 +
 src/CliCommands/GenerateShortcodeCommand.php | 95 ++++++++++++++++++++
 4 files changed, 108 insertions(+), 11 deletions(-)
 create mode 100644 src/CliCommands/GenerateShortcodeCommand.php

diff --git a/bin/cli b/bin/cli
index 0aca7dd0..1816b80f 100755
--- a/bin/cli
+++ b/bin/cli
@@ -1,17 +1,14 @@
 #!/usr/bin/env php
 <?php
+use Acelaya\UrlShortener\CliCommands\GenerateShortcodeCommand;
 use Interop\Container\ContainerInterface;
-use Zend\Diactoros\ServerRequestFactory;
-use Zend\Diactoros\Uri;
-use Zend\Expressive\Application;
+use Symfony\Component\Console\Application as CliApp;
 
 /** @var ContainerInterface $container */
 $container = include __DIR__ . '/../config/container.php';
-/** @var Application $app */
-$app = $container->get(Application::class);
 
-$command = count($_SERVER['argv']) > 1 ? $_SERVER['argv'][1] : '';
-$request = ServerRequestFactory::fromGlobals()
-                                ->withMethod('CLI')
-                                ->withUri(new Uri(sprintf('/%s', $command)));
-$app->run($request);
+$app = new CliApp();
+$app->addCommands([
+    $container->get(GenerateShortcodeCommand::class),
+]);
+$app->run();
diff --git a/composer.json b/composer.json
index d43d7fbb..922e9067 100644
--- a/composer.json
+++ b/composer.json
@@ -20,7 +20,8 @@
         "zendframework/zend-servicemanager": "^3.0",
         "doctrine/orm": "^2.5",
         "guzzlehttp/guzzle": "^6.2",
-        "acelaya/zsm-annotated-services": "^0.2.0"
+        "acelaya/zsm-annotated-services": "^0.2.0",
+        "symfony/console": "^3.0"
     },
     "require-dev": {
         "phpunit/phpunit": "^4.8",
diff --git a/config/autoload/services.global.php b/config/autoload/services.global.php
index 300f1bf3..6027973d 100644
--- a/config/autoload/services.global.php
+++ b/config/autoload/services.global.php
@@ -1,4 +1,5 @@
 <?php
+use Acelaya\UrlShortener\CliCommands;
 use Acelaya\UrlShortener\Factory\CacheFactory;
 use Acelaya\UrlShortener\Factory\EntityManagerFactory;
 use Acelaya\UrlShortener\Middleware;
@@ -38,6 +39,9 @@ return [
             Service\VisitsTracker::class => AnnotatedFactory::class,
             Cache::class => CacheFactory::class,
 
+            // Cli commands
+            CliCommands\GenerateShortcodeCommand::class => AnnotatedFactory::class,
+
             // Middleware
             Middleware\CliRoutable\GenerateShortcodeMiddleware::class => AnnotatedFactory::class,
             Middleware\Routable\RedirectMiddleware::class => AnnotatedFactory::class,
diff --git a/src/CliCommands/GenerateShortcodeCommand.php b/src/CliCommands/GenerateShortcodeCommand.php
new file mode 100644
index 00000000..9f545dce
--- /dev/null
+++ b/src/CliCommands/GenerateShortcodeCommand.php
@@ -0,0 +1,95 @@
+<?php
+namespace Acelaya\UrlShortener\CliCommands;
+
+use Acelaya\UrlShortener\Exception\InvalidUrlException;
+use Acelaya\UrlShortener\Service\UrlShortener;
+use Acelaya\UrlShortener\Service\UrlShortenerInterface;
+use Acelaya\ZsmAnnotatedServices\Annotation\Inject;
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Helper\QuestionHelper;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Question\ChoiceQuestion;
+use Symfony\Component\Console\Question\Question;
+use Zend\Diactoros\Uri;
+
+class GenerateShortcodeCommand extends Command
+{
+    /**
+     * @var UrlShortenerInterface
+     */
+    private $urlShortener;
+    /**
+     * @var array
+     */
+    private $domainConfig;
+
+    /**
+     * GenerateShortcodeCommand constructor.
+     * @param UrlShortenerInterface|UrlShortener $urlShortener
+     * @param array $domainConfig
+     *
+     * @Inject({UrlShortener::class, "config.url_shortener.domain"})
+     */
+    public function __construct(UrlShortenerInterface $urlShortener, array $domainConfig)
+    {
+        parent::__construct(null);
+        $this->urlShortener = $urlShortener;
+        $this->domainConfig = $domainConfig;
+    }
+
+    public function configure()
+    {
+        $this->setName('generate-shortcode')
+             ->setDescription('Generates a shortcode for provided URL and returns the short URL')
+             ->addArgument('longUrl', InputArgument::REQUIRED, 'The long URL to parse');
+    }
+
+    public function interact(InputInterface $input, OutputInterface $output)
+    {
+        $longUrl = $input->getArgument('longUrl');
+        if (! empty($longUrl)) {
+            return;
+        }
+
+        /** @var QuestionHelper $helper */
+        $helper = $this->getHelper('question');
+        $question = new Question(
+            '<question>A long URL was not provided. Which URL do you want to shorten?:</question> '
+        );
+
+        $longUrl = $helper->ask($input, $output, $question);
+        if (! empty($longUrl)) {
+            $input->setArgument('longUrl', $longUrl);
+        }
+    }
+
+    public function execute(InputInterface $input, OutputInterface $output)
+    {
+        $longUrl = $input->getArgument('longUrl');
+
+        try {
+            if (! isset($longUrl)) {
+                $output->writeln('<error>A URL was not provided!</error>');
+                return;
+            }
+
+            $shortcode = $this->urlShortener->urlToShortCode(new Uri($longUrl));
+            $shortUrl = (new Uri())->withPath($shortcode)
+                ->withScheme($this->domainConfig['schema'])
+                ->withHost($this->domainConfig['hostname']);
+
+            $output->writeln([
+                sprintf('Processed URL <info>%s</info>', $longUrl),
+                sprintf('Generated URL <info>%s</info>', $shortUrl),
+            ]);
+        } catch (InvalidUrlException $e) {
+            $output->writeln(
+                sprintf('<error>Provided URL "%s" is invalid. Try with a different one.</error>', $longUrl)
+            );
+        } catch (\Exception $e) {
+            $output->writeln('<error>' . $e . '</error>');
+        }
+    }
+}

From e09915dd211bcd57dbaee755a8592470cd0184c8 Mon Sep 17 00:00:00 2001
From: Alejandro Celaya <alejandro@alejandrocelaya.com>
Date: Sun, 3 Jul 2016 09:16:56 +0200
Subject: [PATCH 2/2] Removed cli-related middlewares and factories

---
 config/autoload/cli-routes.global.php         | 15 ---
 .../autoload/middleware-pipeline.global.php   |  2 -
 config/autoload/services.global.php           |  2 -
 .../GenerateShortcodeMiddleware.php           | 91 -------------------
 .../Factory/CliParamsMiddlewareFactory.php    | 32 -------
 tests/Middleware/CliParamsMiddlewareTest.php  | 91 -------------------
 .../CliParamsMiddlewareFactoryTest.php        | 29 ------
 7 files changed, 262 deletions(-)
 delete mode 100644 config/autoload/cli-routes.global.php
 delete mode 100644 src/Middleware/CliRoutable/GenerateShortcodeMiddleware.php
 delete mode 100644 src/Middleware/Factory/CliParamsMiddlewareFactory.php
 delete mode 100644 tests/Middleware/CliParamsMiddlewareTest.php
 delete mode 100644 tests/Middleware/Factory/CliParamsMiddlewareFactoryTest.php

diff --git a/config/autoload/cli-routes.global.php b/config/autoload/cli-routes.global.php
deleted file mode 100644
index c2aafdf1..00000000
--- a/config/autoload/cli-routes.global.php
+++ /dev/null
@@ -1,15 +0,0 @@
-<?php
-use Acelaya\UrlShortener\Middleware\CliRoutable;
-
-return [
-
-    'routes' => [
-        [
-            'name' => 'cli-generate-shortcode',
-            'path' => '/generate-shortcode',
-            'middleware' => CliRoutable\GenerateShortcodeMiddleware::class,
-            'allowed_methods' => ['CLI'],
-        ],
-    ],
-
-];
diff --git a/config/autoload/middleware-pipeline.global.php b/config/autoload/middleware-pipeline.global.php
index d033f9b2..8a393ce1 100644
--- a/config/autoload/middleware-pipeline.global.php
+++ b/config/autoload/middleware-pipeline.global.php
@@ -1,5 +1,4 @@
 <?php
-use Acelaya\UrlShortener\Middleware\CliParamsMiddleware;
 use Zend\Expressive\Container\ApplicationFactory;
 use Zend\Expressive\Helper;
 
@@ -16,7 +15,6 @@ return [
         'routing' => [
             'middleware' => [
                 ApplicationFactory::ROUTING_MIDDLEWARE,
-                CliParamsMiddleware::class,
                 Helper\UrlHelperMiddleware::class,
                 ApplicationFactory::DISPATCH_MIDDLEWARE,
             ],
diff --git a/config/autoload/services.global.php b/config/autoload/services.global.php
index 6027973d..617242b5 100644
--- a/config/autoload/services.global.php
+++ b/config/autoload/services.global.php
@@ -43,9 +43,7 @@ return [
             CliCommands\GenerateShortcodeCommand::class => AnnotatedFactory::class,
 
             // Middleware
-            Middleware\CliRoutable\GenerateShortcodeMiddleware::class => AnnotatedFactory::class,
             Middleware\Routable\RedirectMiddleware::class => AnnotatedFactory::class,
-            Middleware\CliParamsMiddleware::class => Middleware\Factory\CliParamsMiddlewareFactory::class,
         ],
         'aliases' => [
             'em' => EntityManager::class,
diff --git a/src/Middleware/CliRoutable/GenerateShortcodeMiddleware.php b/src/Middleware/CliRoutable/GenerateShortcodeMiddleware.php
deleted file mode 100644
index 6573ed60..00000000
--- a/src/Middleware/CliRoutable/GenerateShortcodeMiddleware.php
+++ /dev/null
@@ -1,91 +0,0 @@
-<?php
-namespace Acelaya\UrlShortener\Middleware\CliRoutable;
-
-use Acelaya\UrlShortener\Exception\InvalidUrlException;
-use Acelaya\UrlShortener\Service\UrlShortener;
-use Acelaya\UrlShortener\Service\UrlShortenerInterface;
-use Acelaya\ZsmAnnotatedServices\Annotation\Inject;
-use Psr\Http\Message\ResponseInterface as Response;
-use Psr\Http\Message\ServerRequestInterface as Request;
-use Zend\Diactoros\Uri;
-use Zend\Stratigility\MiddlewareInterface;
-
-class GenerateShortcodeMiddleware implements MiddlewareInterface
-{
-    /**
-     * @var UrlShortenerInterface
-     */
-    private $urlShortener;
-    /**
-     * @var array
-     */
-    private $domainConfig;
-
-    /**
-     * GenerateShortcodeMiddleware constructor.
-     *
-     * @param UrlShortenerInterface|UrlShortener $urlShortener
-     * @param array $domainConfig
-     *
-     * @Inject({UrlShortener::class, "config.url_shortener.domain"})
-     */
-    public function __construct(UrlShortenerInterface $urlShortener, array $domainConfig)
-    {
-        $this->urlShortener = $urlShortener;
-        $this->domainConfig = $domainConfig;
-    }
-
-    /**
-     * Process an incoming request and/or response.
-     *
-     * Accepts a server-side request and a response instance, and does
-     * something with them.
-     *
-     * If the response is not complete and/or further processing would not
-     * interfere with the work done in the middleware, or if the middleware
-     * wants to delegate to another process, it can use the `$out` callable
-     * if present.
-     *
-     * If the middleware does not return a value, execution of the current
-     * request is considered complete, and the response instance provided will
-     * be considered the response to return.
-     *
-     * Alternately, the middleware may return a response instance.
-     *
-     * Often, middleware will `return $out();`, with the assumption that a
-     * later middleware will return a response.
-     *
-     * @param Request $request
-     * @param Response $response
-     * @param null|callable $out
-     * @return null|Response
-     */
-    public function __invoke(Request $request, Response $response, callable $out = null)
-    {
-        $longUrl = $request->getAttribute('longUrl');
-
-        try {
-            if (! isset($longUrl)) {
-                $response->getBody()->write('A URL was not provided!' . PHP_EOL);
-                return;
-            }
-
-            $shortcode = $this->urlShortener->urlToShortCode(new Uri($longUrl));
-            $shortUrl = (new Uri())->withPath($shortcode)
-                                   ->withScheme($this->domainConfig['schema'])
-                                   ->withHost($this->domainConfig['hostname']);
-
-            $response->getBody()->write(
-                sprintf('Processed URL "%s".%sGenerated short URL "%s"', $longUrl, PHP_EOL, $shortUrl) . PHP_EOL
-            );
-        } catch (InvalidUrlException $e) {
-            $response->getBody()->write(
-                sprintf('Provided URL "%s" is invalid. Try with a different one.', $longUrl) . PHP_EOL
-            );
-        } catch (\Exception $e) {
-            $response->getBody()->write($e);
-        } finally {
-            return $response;
-        }
-    }
-}
diff --git a/src/Middleware/Factory/CliParamsMiddlewareFactory.php b/src/Middleware/Factory/CliParamsMiddlewareFactory.php
deleted file mode 100644
index 9be7f52e..00000000
--- a/src/Middleware/Factory/CliParamsMiddlewareFactory.php
+++ /dev/null
@@ -1,32 +0,0 @@
-<?php
-namespace Acelaya\UrlShortener\Middleware\Factory;
-
-use Acelaya\UrlShortener\Middleware\CliParamsMiddleware;
-use Interop\Container\ContainerInterface;
-use Interop\Container\Exception\ContainerException;
-use Zend\ServiceManager\Exception\ServiceNotCreatedException;
-use Zend\ServiceManager\Exception\ServiceNotFoundException;
-use Zend\ServiceManager\Factory\FactoryInterface;
-
-class CliParamsMiddlewareFactory implements FactoryInterface
-{
-    /**
-     * Create an object
-     *
-     * @param  ContainerInterface $container
-     * @param  string $requestedName
-     * @param  null|array $options
-     * @return object
-     * @throws ServiceNotFoundException if unable to resolve the service.
-     * @throws ServiceNotCreatedException if an exception is raised when
-     *     creating a service.
-     * @throws ContainerException if any other error occurs
-     */
-    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
-    {
-        return new CliParamsMiddleware(
-            isset($_SERVER['argv']) ? $_SERVER['argv'] : [],
-            php_sapi_name()
-        );
-    }
-}
diff --git a/tests/Middleware/CliParamsMiddlewareTest.php b/tests/Middleware/CliParamsMiddlewareTest.php
deleted file mode 100644
index e07d05c0..00000000
--- a/tests/Middleware/CliParamsMiddlewareTest.php
+++ /dev/null
@@ -1,91 +0,0 @@
-<?php
-namespace AcelayaTest\UrlShortener\Middleware;
-
-use Acelaya\UrlShortener\Middleware\CliParamsMiddleware;
-use PHPUnit_Framework_TestCase as TestCase;
-use Psr\Http\Message\ServerRequestInterface;
-use Zend\Diactoros\Response;
-use Zend\Diactoros\ServerRequestFactory;
-use Zend\Expressive\Router\RouteResult;
-
-class CliParamsMiddlewareTest extends TestCase
-{
-    /**
-     * @test
-     */
-    public function nonCliRequestsJustInvokeNextMiddleware()
-    {
-        $middleware = new CliParamsMiddleware([], 'non-cli');
-
-        $invoked = false;
-        $originalResponse = new Response();
-
-        $response = $middleware->__invoke(
-            ServerRequestFactory::fromGlobals(),
-            $originalResponse,
-            function ($req, $resp) use (&$invoked) {
-                $invoked = true;
-                return $resp;
-            }
-        );
-
-        $this->assertSame($originalResponse, $response);
-        $this->assertTrue($invoked);
-    }
-
-    /**
-     * @test
-     */
-    public function nonSuccessRouteResultJustInvokesNextMiddleware()
-    {
-        $middleware = new CliParamsMiddleware([], 'cli');
-
-        $invoked = false;
-        $originalResponse = new Response();
-        $routeResult = $this->prophesize(RouteResult::class);
-        $routeResult->isSuccess()->willReturn(false)->shouldBeCalledTimes(1);
-
-        $response = $middleware->__invoke(
-            ServerRequestFactory::fromGlobals()->withAttribute(RouteResult::class, $routeResult->reveal()),
-            $originalResponse,
-            function ($req, $resp) use (&$invoked) {
-                $invoked = true;
-                return $resp;
-            }
-        );
-
-        $this->assertSame($originalResponse, $response);
-        $this->assertTrue($invoked);
-    }
-
-    /**
-     * @test
-     */
-    public function properRouteWillInjectAttributeInResponse()
-    {
-        $expectedLongUrl = 'http://www.google.com';
-        $middleware = new CliParamsMiddleware(['foo', 'bar', $expectedLongUrl], 'cli');
-
-        $invoked = false;
-        $originalResponse = new Response();
-        $routeResult = $this->prophesize(RouteResult::class);
-        $routeResult->isSuccess()->willReturn(true)->shouldBeCalledTimes(1);
-        $routeResult->getMatchedRouteName()->willReturn('cli-generate-shortcode')->shouldBeCalledTimes(1);
-        /** @var ServerRequestInterface $request */
-        $request = null;
-
-        $response = $middleware->__invoke(
-            ServerRequestFactory::fromGlobals()->withAttribute(RouteResult::class, $routeResult->reveal()),
-            $originalResponse,
-            function ($req, $resp) use (&$invoked, &$request) {
-                $invoked = true;
-                $request = $req;
-                return $resp;
-            }
-        );
-
-        $this->assertSame($originalResponse, $response);
-        $this->assertEquals($expectedLongUrl, $request->getAttribute('longUrl'));
-        $this->assertTrue($invoked);
-    }
-}
diff --git a/tests/Middleware/Factory/CliParamsMiddlewareFactoryTest.php b/tests/Middleware/Factory/CliParamsMiddlewareFactoryTest.php
deleted file mode 100644
index 3fad4bab..00000000
--- a/tests/Middleware/Factory/CliParamsMiddlewareFactoryTest.php
+++ /dev/null
@@ -1,29 +0,0 @@
-<?php
-namespace AcelayaTest\UrlShortener\Middleware\Factory;
-
-use Acelaya\UrlShortener\Middleware\CliParamsMiddleware;
-use Acelaya\UrlShortener\Middleware\Factory\CliParamsMiddlewareFactory;
-use PHPUnit_Framework_TestCase as TestCase;
-use Zend\ServiceManager\ServiceManager;
-
-class CliParamsMiddlewareFactoryTest extends TestCase
-{
-    /**
-     * @var CliParamsMiddlewareFactory
-     */
-    protected $factory;
-
-    public function setUp()
-    {
-        $this->factory = new CliParamsMiddlewareFactory();
-    }
-
-    /**
-     * @test
-     */
-    public function serviceIsCreated()
-    {
-        $instance = $this->factory->__invoke(new ServiceManager(), '');
-        $this->assertInstanceOf(CliParamsMiddleware::class, $instance);
-    }
-}