From 32fdb257a3f46922b6f85acbdd82c35872389221 Mon Sep 17 00:00:00 2001
From: Alejandro Celaya <alejandro@alejandrocelaya.com>
Date: Mon, 15 Feb 2021 22:16:58 +0100
Subject: [PATCH] Fixed migration that could be incorrectly skipped due to
 wrong condition being used

---
 data/migrations/Version20210207100807.php | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/data/migrations/Version20210207100807.php b/data/migrations/Version20210207100807.php
index a74c0b08..24e73d34 100644
--- a/data/migrations/Version20210207100807.php
+++ b/data/migrations/Version20210207100807.php
@@ -15,10 +15,9 @@ final class Version20210207100807 extends AbstractMigration
     public function up(Schema $schema): void
     {
         $visits = $schema->getTable('visits');
+        $this->skipIf($visits->hasColumn('visited_url'));
+
         $shortUrlId = $visits->getColumn('short_url_id');
-
-        $this->skipIf(! $shortUrlId->getNotnull());
-
         $shortUrlId->setNotnull(false);
 
         $visits->addColumn('visited_url', Types::STRING, [
@@ -34,10 +33,9 @@ final class Version20210207100807 extends AbstractMigration
     public function down(Schema $schema): void
     {
         $visits = $schema->getTable('visits');
+        $this->skipIf(! $visits->hasColumn('visited_url'));
+
         $shortUrlId = $visits->getColumn('short_url_id');
-
-        $this->skipIf($shortUrlId->getNotnull());
-
         $shortUrlId->setNotnull(true);
         $visits->dropColumn('visited_url');
         $visits->dropColumn('type');