Mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2026-03-06 23:33:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Ensured database connection is closed even if an error is thrown during dispatch process

Browse Source
This commit is contained in:
Alejandro Celaya
2019-07-31 20:08:46 +02:00
parent e6a63a9b85
commit 406de16a0d
2 changed files with 35 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
module/Common/test/Middleware/CloseDbConnectionMiddlewareTest.php
View File

@@ -8,6 +8,7 @@ use Doctrine\ORM\EntityManagerInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\Prophecy\ObjectProphecy;
use Psr\Http\Server\RequestHandlerInterface;
use RuntimeException;
use Shlinkio\Shlink\Common\Middleware\CloseDbConnectionMiddleware;
use Zend\Diactoros\Response;
use Zend\Diactoros\ServerRequest;
@@ -20,35 +21,52 @@ class CloseDbConnectionMiddlewareTest extends TestCase
private $handler;
/** @var ObjectProphecy */
private $em;
/** @var ObjectProphecy */
private $conn;
public function setUp(): void
{
$this->handler = $this->prophesize(RequestHandlerInterface::class);
$this->em = $this->prophesize(EntityManagerInterface::class);
$this->conn = $this->prophesize(Connection::class);
$this->conn->close()->will(function () {
});
$this->em->getConnection()->willReturn($this->conn->reveal());
$this->em->clear()->will(function () {
});
$this->middleware = new CloseDbConnectionMiddleware($this->em->reveal());
}
/** @test */
public function connectionIsClosedWhenMiddlewareIsProcessed()
public function connectionIsClosedWhenMiddlewareIsProcessed(): void
{
$req = new ServerRequest();
$resp = new Response();
$conn = $this->prophesize(Connection::class);
$closeConn = $conn->close()->will(function () {
});
$getConn = $this->em->getConnection()->willReturn($conn->reveal());
$clear = $this->em->clear()->will(function () {
});
$handle = $this->handler->handle($req)->willReturn($resp);
$result = $this->middleware->process($req, $this->handler->reveal());
$this->assertSame($result, $resp);
$getConn->shouldHaveBeenCalledOnce();
$closeConn->shouldHaveBeenCalledOnce();
$clear->shouldHaveBeenCalledOnce();
$this->em->getConnection()->shouldHaveBeenCalledOnce();
$this->conn->close()->shouldHaveBeenCalledOnce();
$this->em->clear()->shouldHaveBeenCalledOnce();
$handle->shouldHaveBeenCalledOnce();
}
/** @test */
public function connectionIsClosedEvenIfExceptionIsThrownOnInnerMiddlewares(): void
{
$req = new ServerRequest();
$expectedError = new RuntimeException();
$this->handler->handle($req)->willThrow($expectedError)
->shouldBeCalledOnce();
$this->em->getConnection()->shouldBeCalledOnce();
$this->conn->close()->shouldBeCalledOnce();
$this->em->clear()->shouldBeCalledOnce();
$this->expectExceptionObject($expectedError);
$this->middleware->process($req, $this->handler->reveal());
}
}