Increased MSI to 64%

module/Common/src/Factory/CacheFactory.php

@@ -45,11 +45,7 @@ class CacheFactory implements FactoryInterface
         return $adapter;
     }
 
-    /**
-     * @param ContainerInterface $container
-     * @return Cache\CacheProvider
-     */
-    protected function getAdapter(ContainerInterface $container)
+    private function getAdapter(ContainerInterface $container): Cache\CacheProvider
     {
         // Try to get the adapter from config
         $config = $container->get('config');
@@ -61,11 +57,7 @@ class CacheFactory implements FactoryInterface
         return env('APP_ENV', 'pro') === 'pro' ? new Cache\ApcuCache() : new Cache\ArrayCache();
     }
 
-    /**
-     * @param array $cacheConfig
-     * @return Cache\CacheProvider
-     */
-    protected function resolveCacheAdapter(array $cacheConfig)
+    private function resolveCacheAdapter(array $cacheConfig): Cache\CacheProvider
     {
         switch ($cacheConfig['adapter']) {
             case Cache\ArrayCache::class:

module/Common/src/Image/ImageFactory.php

@@ -27,9 +27,9 @@ class ImageFactory implements FactoryInterface
     public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
     {
         $config = $container->get('config')['phpwkhtmltopdf'];
-        $image = new Image(isset($config['images']) ? $config['images'] : null);
+        $image = new Image($config['images'] ?? null);
 
-        if (isset($options) && isset($options['url'])) {
+        if ($options['url'] ?? null) {
             $image->setPage($options['url']);
         }
 

module/Common/src/Middleware/LocaleMiddleware.php

@@ -45,11 +45,7 @@ class LocaleMiddleware implements MiddlewareInterface
         return $delegate->handle($request);
     }
 
-    /**
-     * @param string $locale
-     * @return string
-     */
-    protected function normalizeLocale($locale)
+    private function normalizeLocale(string $locale): string
     {
         $parts = explode('_', $locale);
         if (count($parts) > 1) {

module/Common/src/Response/PixelResponse.php

@@ -27,7 +27,7 @@ class PixelResponse extends Response
     private function createBody(): StreamInterface
     {
         $body = new Stream('php://temp', 'wb+');
-        $body->write((string) base64_decode(self::BASE_64_IMAGE));
+        $body->write(base64_decode(self::BASE_64_IMAGE));
         $body->rewind();
         return $body;
     }

module/Common/src/Util/ResponseUtilsTrait.php

@@ -9,28 +9,15 @@ use Zend\Diactoros\Response;
 use Zend\Diactoros\Stream;
 use Zend\Stdlib\ArrayUtils;
 use const FILEINFO_MIME;
-use function basename;
 
 trait ResponseUtilsTrait
 {
-    protected function generateDownloadFileResponse(string $filePath): ResponseInterface
-    {
-        return $this->generateBinaryResponse($filePath, [
-            'Content-Disposition' => 'attachment; filename=' . basename($filePath),
-            'Content-Transfer-Encoding' => 'Binary',
-            'Content-Description' => 'File Transfer',
-            'Pragma' => 'public',
-            'Expires' => '0',
-            'Cache-Control' => 'must-revalidate',
-        ]);
-    }
-
-    protected function generateImageResponse(string $imagePath): ResponseInterface
+    private function generateImageResponse(string $imagePath): ResponseInterface
     {
         return $this->generateBinaryResponse($imagePath);
     }
 
-    protected function generateBinaryResponse(string $path, array $extraHeaders = []): ResponseInterface
+    private function generateBinaryResponse(string $path, array $extraHeaders = []): ResponseInterface
     {
         $body = new Stream($path);
         return new Response($body, 200, ArrayUtils::merge([