From 1401dd9156be9f09d7b1412894ff28ef6bbc2095 Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Fri, 10 Jul 2020 23:25:31 +0200 Subject: [PATCH] Fixed issue introduced with league/uri library --- module/Core/src/Action/AbstractTrackingAction.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/module/Core/src/Action/AbstractTrackingAction.php b/module/Core/src/Action/AbstractTrackingAction.php index 4bf391c7..08a35855 100644 --- a/module/Core/src/Action/AbstractTrackingAction.php +++ b/module/Core/src/Action/AbstractTrackingAction.php @@ -68,13 +68,13 @@ abstract class AbstractTrackingAction implements MiddlewareInterface, RequestMet private function buildUrlToRedirectTo(ShortUrl $shortUrl, array $currentQuery, ?string $disableTrackParam): string { $uri = Uri::createFromString($shortUrl->getLongUrl()); - $hardcodedQuery = parse_query($uri->getQuery()); + $hardcodedQuery = parse_query($uri->getQuery() ?? ''); if ($disableTrackParam !== null) { unset($currentQuery[$disableTrackParam]); } $mergedQuery = array_merge($hardcodedQuery, $currentQuery); - return (string) $uri->withQuery(build_query($mergedQuery)); + return (string) (empty($mergedQuery) ? $uri : $uri->withQuery(build_query($mergedQuery))); } private function shouldTrackRequest(ServerRequestInterface $request, array $query, ?string $disableTrackParam): bool