Mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2026-03-06 23:33:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary flush calls when used in wrapInTransaction

Browse Source
This commit is contained in:
Alejandro Celaya
2024-11-11 09:31:23 +01:00
parent 59a4704658
commit 7ca605e216
3 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
module/Rest/src/ApiKey/Repository/ApiKeyRepository.php
View File

@@ -36,7 +36,6 @@ class ApiKeyRepository extends EntitySpecificationRepository implements ApiKeyRe
$initialApiKey = ApiKey::fromMeta(ApiKeyMeta::fromParams(key: $apiKey));
$em->persist($initialApiKey);
$em->flush();
return $initialApiKey;
});

8
module/Rest/src/Service/ApiKeyService.php
View File

@@ -27,7 +27,6 @@ readonly class ApiKeyService implements ApiKeyServiceInterface
return $this->em->wrapInTransaction(function () use ($apiKeyMeta) {
$apiKey = ApiKey::fromMeta($this->ensureUniqueName($apiKeyMeta));
$this->em->persist($apiKey);
$this->em->flush();
return $apiKey;
});
@@ -120,7 +119,7 @@ readonly class ApiKeyService implements ApiKeyServiceInterface
return $apiKey;
}
return $this->em->wrapInTransaction(function () use ($apiKeyRenaming, $apiKey) {
$this->em->wrapInTransaction(function () use ($apiKeyRenaming, $apiKey): void {
if ($this->repo->nameExists($apiKeyRenaming->newName)) {
throw new InvalidArgumentException(
sprintf('Another API key with name "%s" already exists', $apiKeyRenaming->newName),
@@ -128,10 +127,9 @@ readonly class ApiKeyService implements ApiKeyServiceInterface
}
$apiKey->name = $apiKeyRenaming->newName;
$this->em->flush();
return $apiKey;
});
return $apiKey;
}
private function findByKey(string $key): ApiKey|null