Improved public API in Visit entity, reducing anemic model

2026-03-06 23:33:13 +08:00 · 2018-10-28 16:20:10 +01:00
parent 8e1e8ba7de
commit 951d08f914
9 changed files with 60 additions and 94 deletions
--- a/module/Core/src/Service/VisitsTracker.php
+++ b/module/Core/src/Service/VisitsTracker.php
@@ -34,11 +34,7 @@ class VisitsTracker implements VisitsTrackerInterface
            'shortCode' => $shortCode,
        ]);

-        $visit = new Visit();
-        $visit->setShortUrl($shortUrl)
-              ->setUserAgent($visitor->getUserAgent())
-              ->setReferer($visitor->getReferer())
-              ->setRemoteAddr($visitor->getRemoteAddress());
+        $visit = new Visit($shortUrl, $visitor);

        /** @var ORM\EntityManager $em */
        $em = $this->em;