From 9577a4da4be68d30a0a37b18cb370deaf89b4f50 Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Mon, 23 Oct 2017 12:36:03 +0200 Subject: [PATCH] Refactored ShortUrlRepository to make it more readable --- module/Core/src/Repository/ShortUrlRepository.php | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/module/Core/src/Repository/ShortUrlRepository.php b/module/Core/src/Repository/ShortUrlRepository.php index 7223b188..6a1d1545 100644 --- a/module/Core/src/Repository/ShortUrlRepository.php +++ b/module/Core/src/Repository/ShortUrlRepository.php @@ -50,22 +50,14 @@ class ShortUrlRepository extends EntityRepository implements ShortUrlRepositoryI $fieldName = is_array($orderBy) ? key($orderBy) : $orderBy; $order = is_array($orderBy) ? $orderBy[$fieldName] : 'ASC'; - if (in_array($fieldName, [ - 'visits', - 'visitsCount', - 'visitCount', - ], true)) { + if (in_array($fieldName, ['visits', 'visitsCount', 'visitCount'], true)) { $qb->addSelect('COUNT(v) AS totalVisits') ->leftJoin('s.visits', 'v') ->groupBy('s') ->orderBy('totalVisits', $order); return array_column($qb->getQuery()->getResult(), 0); - } elseif (in_array($fieldName, [ - 'originalUrl', - 'shortCode', - 'dateCreated', - ], true)) { + } elseif (in_array($fieldName, ['originalUrl', 'shortCode', 'dateCreated'], true)) { $qb->orderBy('s.' . $fieldName, $order); }