Mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2026-03-06 15:23:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Removed generic error handling from action that will usually be handled by ErrorHandler middleware

Browse Source
This commit is contained in:
Alejandro Celaya
2019-11-20 20:21:02 +01:00
parent 84c4631124
commit 98b6dba05d
2 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
module/Rest/src/Action/ShortUrl/AbstractCreateShortUrlAction.php
View File

@@ -15,7 +15,6 @@ use Shlinkio\Shlink\Core\Service\UrlShortenerInterface;
use Shlinkio\Shlink\Core\Transformer\ShortUrlDataTransformer;
use Shlinkio\Shlink\Rest\Action\AbstractRestAction;
use Shlinkio\Shlink\Rest\Util\RestUtils;
use Throwable;
use Zend\Diactoros\Response\JsonResponse;
use function sprintf;
@@ -74,12 +73,6 @@ abstract class AbstractCreateShortUrlAction extends AbstractRestAction
'error' => RestUtils::getRestErrorCodeFromException($e),
'message' => sprintf('Provided slug %s is already in use. Try with a different one.', $customSlug),
], self::STATUS_BAD_REQUEST);
} catch (Throwable $e) {
$this->logger->error('Unexpected error creating short url. {e}', ['e' => $e]);
return new JsonResponse([
'error' => RestUtils::UNKNOWN_ERROR,
'message' => 'Unexpected error occurred',
], self::STATUS_INTERNAL_SERVER_ERROR);
}
}