Mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2026-03-06 23:33:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update VisitsTracker so that its methods return the new Visit instance, if any

Browse Source
This commit is contained in:
Alejandro Celaya
2024-11-11 08:51:55 +01:00
parent 12a08cb373
commit a5a98bd578
29 changed files with 104 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
module/Core/test/Visit/VisitsTrackerTest.php
View File

@@ -33,43 +33,44 @@ class VisitsTrackerTest extends TestCase
#[Test, DataProvider('provideTrackingMethodNames')]
public function trackPersistsVisitAndDispatchesEvent(string $method, array $args): void
{
$this->em->expects($this->once())->method('persist')->with(
$this->callback(fn (Visit $visit) => $visit->setId('1') !== null),
);
$this->em->expects($this->once())->method('flush');
$this->em->expects($this->once())->method('persist')->with($this->isInstanceOf(Visit::class));
$this->eventDispatcher->expects($this->once())->method('dispatch')->with(
$this->isInstanceOf(UrlVisited::class),
);
$this->visitsTracker()->{$method}(...$args);
$result = $this->visitsTracker()->{$method}(...$args);
self::assertInstanceOf(Visit::class, $result);
}
#[Test, DataProvider('provideTrackingMethodNames')]
public function trackingIsSkippedCompletelyWhenDisabledFromOptions(string $method, array $args): void
{
$this->em->expects($this->never())->method('persist');
$this->em->expects($this->never())->method('flush');
$this->eventDispatcher->expects($this->never())->method('dispatch');
$this->visitsTracker(new TrackingOptions(disableTracking: true))->{$method}(...$args);
$result = $this->visitsTracker(new TrackingOptions(disableTracking: true))->{$method}(...$args);
self::assertNull($result);
}
public static function provideTrackingMethodNames(): iterable
{
yield 'track' => ['track', [ShortUrl::createFake(), Visitor::emptyInstance()]];
yield 'trackInvalidShortUrlVisit' => ['trackInvalidShortUrlVisit', [Visitor::emptyInstance()]];
yield 'trackBaseUrlVisit' => ['trackBaseUrlVisit', [Visitor::emptyInstance()]];
yield 'trackRegularNotFoundVisit' => ['trackRegularNotFoundVisit', [Visitor::emptyInstance()]];
yield 'track' => ['track', [ShortUrl::createFake(), Visitor::empty()]];
yield 'trackInvalidShortUrlVisit' => ['trackInvalidShortUrlVisit', [Visitor::empty()]];
yield 'trackBaseUrlVisit' => ['trackBaseUrlVisit', [Visitor::empty()]];
yield 'trackRegularNotFoundVisit' => ['trackRegularNotFoundVisit', [Visitor::empty()]];
}
#[Test, DataProvider('provideOrphanTrackingMethodNames')]
public function orphanVisitsAreNotTrackedWhenDisabled(string $method): void
{
$this->em->expects($this->never())->method('persist');
$this->em->expects($this->never())->method('flush');
$this->eventDispatcher->expects($this->never())->method('dispatch');
$this->visitsTracker(new TrackingOptions(trackOrphanVisits: false))->{$method}(Visitor::emptyInstance());
$result = $this->visitsTracker(new TrackingOptions(trackOrphanVisits: false))->{$method}(Visitor::empty());
self::assertNull($result);
}
public static function provideOrphanTrackingMethodNames(): iterable