From a79c1f580e3058546cc5d13b87d1f5e98ff7a542 Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Wed, 1 Aug 2018 20:31:54 +0200 Subject: [PATCH] Fixed visits count multiplied by the number of tags when ordering and filtering by text --- module/Core/src/Repository/ShortUrlRepository.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/Core/src/Repository/ShortUrlRepository.php b/module/Core/src/Repository/ShortUrlRepository.php index 3919402f..04a5b6e6 100644 --- a/module/Core/src/Repository/ShortUrlRepository.php +++ b/module/Core/src/Repository/ShortUrlRepository.php @@ -51,7 +51,7 @@ class ShortUrlRepository extends EntityRepository implements ShortUrlRepositoryI $order = \is_array($orderBy) ? $orderBy[$fieldName] : 'ASC'; if (\in_array($fieldName, ['visits', 'visitsCount', 'visitCount'], true)) { - $qb->addSelect('COUNT(v) AS totalVisits') + $qb->addSelect('COUNT(DISTINCT v) AS totalVisits') ->leftJoin('s.visits', 'v') ->groupBy('s') ->orderBy('totalVisits', $order);