From c8eb956778ab489301473a4c691c8c23e5d4de61 Mon Sep 17 00:00:00 2001
From: Alejandro Celaya <alejandro@alejandrocelaya.com>
Date: Sun, 10 Jan 2021 09:32:19 +0100
Subject: [PATCH] Improved list domains api test to cover different API key
 cases

---
 .../Rest/test-api/Action/ListDomainsTest.php  | 54 +++++++++++++------
 1 file changed, 37 insertions(+), 17 deletions(-)

diff --git a/module/Rest/test-api/Action/ListDomainsTest.php b/module/Rest/test-api/Action/ListDomainsTest.php
index 045197e8..cf3167f8 100644
--- a/module/Rest/test-api/Action/ListDomainsTest.php
+++ b/module/Rest/test-api/Action/ListDomainsTest.php
@@ -8,30 +8,50 @@ use Shlinkio\Shlink\TestUtils\ApiTest\ApiTestCase;
 
 class ListDomainsTest extends ApiTestCase
 {
-    /** @test */
-    public function domainsAreProperlyListed(): void
+    /**
+     * @test
+     * @dataProvider provideApiKeysAndDomains
+     */
+    public function domainsAreProperlyListed(string $apiKey, array $expectedDomains): void
     {
-        $resp = $this->callApiWithKey(self::METHOD_GET, '/domains');
+        $resp = $this->callApiWithKey(self::METHOD_GET, '/domains', [], $apiKey);
         $respPayload = $this->getJsonResponsePayload($resp);
 
         self::assertEquals(self::STATUS_OK, $resp->getStatusCode());
         self::assertEquals([
             'domains' => [
-                'data' => [
-                    [
-                        'domain' => 'doma.in',
-                        'isDefault' => true,
-                    ],
-                    [
-                        'domain' => 'example.com',
-                        'isDefault' => false,
-                    ],
-                    [
-                        'domain' => 'some-domain.com',
-                        'isDefault' => false,
-                    ],
-                ],
+                'data' => $expectedDomains,
             ],
         ], $respPayload);
     }
+
+    public function provideApiKeysAndDomains(): iterable
+    {
+        yield 'admin API key' => ['valid_api_key', [
+            [
+                'domain' => 'doma.in',
+                'isDefault' => true,
+            ],
+            [
+                'domain' => 'example.com',
+                'isDefault' => false,
+            ],
+            [
+                'domain' => 'some-domain.com',
+                'isDefault' => false,
+            ],
+        ]];
+        yield 'author API key' => ['author_api_key', [
+            [
+                'domain' => 'doma.in',
+                'isDefault' => true,
+            ],
+        ]];
+        yield 'domain API key' => ['domain_api_key', [
+            [
+                'domain' => 'example.com',
+                'isDefault' => false,
+            ],
+        ]];
+    }
 }