Move logic to serialize ShortUrls to entity itself

This commit is contained in:
Alejandro Celaya
2024-03-18 22:09:15 +01:00
parent 457a7a14e5
commit e028d8ea31
5 changed files with 42 additions and 83 deletions

View File

@@ -132,7 +132,7 @@ class PublishingUpdatesGeneratorTest extends TestCase
'maxVisits' => null,
],
'domain' => null,
'title' => $shortUrl->title(),
'title' => 'The title',
'crawlable' => false,
'forwardQuery' => true,
'visitsSummary' => VisitsSummary::fromTotalAndNonBots(0, 0),

View File

@@ -70,9 +70,11 @@ class ShortUrlServiceTest extends TestCase
);
self::assertSame($shortUrl, $result);
self::assertEquals($shortUrlEdit->validSince, $shortUrl->getValidSince());
self::assertEquals($shortUrlEdit->validUntil, $shortUrl->getValidUntil());
self::assertEquals($shortUrlEdit->maxVisits, $shortUrl->getMaxVisits());
['validSince' => $since, 'validUntil' => $until, 'maxVisits' => $maxVisits] = $shortUrl->toArray()['meta'];
self::assertEquals($shortUrlEdit->validSince?->toAtomString(), $since);
self::assertEquals($shortUrlEdit->validUntil?->toAtomString(), $until);
self::assertEquals($shortUrlEdit->maxVisits, $maxVisits);
self::assertEquals($shortUrlEdit->longUrl ?? $originalLongUrl, $shortUrl->getLongUrl());
}