Migrated all constructor props to property promotion when possible

module/Core/functions/functions.php

@@ -51,20 +51,12 @@ function parseDateRangeFromQuery(array $query, string $startDateName, string $en
     $startDate = parseDateFromQuery($query, $startDateName);
     $endDate = parseDateFromQuery($query, $endDateName);
 
-    // TODO Use match expression when migrating to PHP8
-    if ($startDate === null && $endDate === null) {
-        return DateRange::emptyInstance();
-    }
-
-    if ($startDate !== null && $endDate !== null) {
-        return DateRange::withStartAndEndDate($startDate, $endDate);
-    }
-
-    if ($startDate !== null) {
-        return DateRange::withStartDate($startDate);
-    }
-
-    return DateRange::withEndDate($endDate);
+    return match (true) {
+        $startDate === null && $endDate === null => DateRange::emptyInstance(),
+        $startDate !== null && $endDate !== null => DateRange::withStartAndEndDate($startDate, $endDate),
+        $startDate !== null => DateRange::withStartDate($startDate),
+        default => DateRange::withEndDate($endDate),
+    };
 }
 
 /**

module/Core/src/Action/AbstractTrackingAction.php

@@ -27,20 +27,14 @@ use function array_merge;
 
 abstract class AbstractTrackingAction implements MiddlewareInterface, RequestMethodInterface
 {
-    private ShortUrlResolverInterface $urlResolver;
-    private VisitsTrackerInterface $visitTracker;
-    private TrackingOptions $trackingOptions;
     private LoggerInterface $logger;
 
     public function __construct(
-        ShortUrlResolverInterface $urlResolver,
-        VisitsTrackerInterface $visitTracker,
-        TrackingOptions $trackingOptions,
+        private ShortUrlResolverInterface $urlResolver,
+        private VisitsTrackerInterface $visitTracker,
+        private TrackingOptions $trackingOptions,
         ?LoggerInterface $logger = null
     ) {
-        $this->urlResolver = $urlResolver;
-        $this->visitTracker = $visitTracker;
-        $this->trackingOptions = $trackingOptions;
         $this->logger = $logger ?? new NullLogger();
     }
 

module/Core/src/Action/QrCodeAction.php

@@ -24,18 +24,14 @@ class QrCodeAction implements MiddlewareInterface
     private const MIN_SIZE = 50;
     private const MAX_SIZE = 1000;
 
-    private ShortUrlResolverInterface $urlResolver;
-    private ShortUrlStringifierInterface $stringifier;
     private LoggerInterface $logger;
 
     public function __construct(
-        ShortUrlResolverInterface $urlResolver,
-        ShortUrlStringifierInterface $stringifier,
+        private ShortUrlResolverInterface $urlResolver,
+        private ShortUrlStringifierInterface $stringifier,
         ?LoggerInterface $logger = null
     ) {
-        $this->urlResolver = $urlResolver;
         $this->logger = $logger ?? new NullLogger();
-        $this->stringifier = $stringifier;
     }
 
     public function process(Request $request, RequestHandlerInterface $handler): Response

module/Core/src/Action/RedirectAction.php

@@ -16,17 +16,14 @@ use Shlinkio\Shlink\Core\Visit\VisitsTrackerInterface;
 
 class RedirectAction extends AbstractTrackingAction implements StatusCodeInterface
 {
-    private RedirectResponseHelperInterface $redirectResponseHelper;
-
     public function __construct(
         ShortUrlResolverInterface $urlResolver,
         VisitsTrackerInterface $visitTracker,
         Options\TrackingOptions $trackingOptions,
-        RedirectResponseHelperInterface $redirectResponseHelper,
+        private RedirectResponseHelperInterface $redirectResponseHelper,
         ?LoggerInterface $logger = null
     ) {
         parent::__construct($urlResolver, $visitTracker, $trackingOptions, $logger);
-        $this->redirectResponseHelper = $redirectResponseHelper;
     }
 
     protected function createSuccessResp(string $longUrl): Response

module/Core/src/Action/RobotsAction.php

@@ -17,11 +17,8 @@ use const PHP_EOL;
 
 class RobotsAction implements RequestHandlerInterface, StatusCodeInterface
 {
-    private CrawlingHelperInterface $crawlingHelper;
-
-    public function __construct(CrawlingHelperInterface $crawlingHelper)
+    public function __construct(private CrawlingHelperInterface $crawlingHelper)
     {
-        $this->crawlingHelper = $crawlingHelper;
     }
 
     public function handle(ServerRequestInterface $request): ResponseInterface

module/Core/src/Crawling/CrawlingHelper.php

@@ -10,11 +10,8 @@ use Shlinkio\Shlink\Core\Repository\ShortUrlRepositoryInterface;
 
 class CrawlingHelper implements CrawlingHelperInterface
 {
-    private EntityManagerInterface $em;
-
-    public function __construct(EntityManagerInterface $em)
+    public function __construct(private EntityManagerInterface $em)
     {
-        $this->em = $em;
     }
 
     public function listCrawlableShortCodes(): iterable

module/Core/src/Domain/DomainService.php

@@ -16,13 +16,8 @@ use function Functional\map;
 
 class DomainService implements DomainServiceInterface
 {
-    private EntityManagerInterface $em;
-    private string $defaultDomain;
-
-    public function __construct(EntityManagerInterface $em, string $defaultDomain)
+    public function __construct(private EntityManagerInterface $em, private string $defaultDomain)
     {
-        $this->em = $em;
-        $this->defaultDomain = $defaultDomain;
     }
 
     /**

module/Core/src/Domain/Model/DomainItem.php

@@ -8,13 +8,8 @@ use JsonSerializable;
 
 final class DomainItem implements JsonSerializable
 {
-    private string $domain;
-    private bool $isDefault;
-
-    public function __construct(string $domain, bool $isDefault)
+    public function __construct(private string $domain, private bool $isDefault)
     {
-        $this->domain = $domain;
-        $this->isDefault = $isDefault;
     }
 
     public function jsonSerialize(): array

module/Core/src/Entity/Domain.php

@@ -9,11 +9,8 @@ use Shlinkio\Shlink\Common\Entity\AbstractEntity;
 
 class Domain extends AbstractEntity implements JsonSerializable
 {
-    private string $authority;
-
-    public function __construct(string $authority)
+    public function __construct(private string $authority)
     {
-        $this->authority = $authority;
     }
 
     public function getAuthority(): string

module/Core/src/Entity/Tag.php

@@ -10,12 +10,10 @@ use Shlinkio\Shlink\Common\Entity\AbstractEntity;
 
 class Tag extends AbstractEntity implements JsonSerializable
 {
-    private string $name;
     private Collections\Collection $shortUrls;
 
-    public function __construct(string $name)
+    public function __construct(private string $name)
     {
-        $this->name = $name;
         $this->shortUrls = new Collections\ArrayCollection();
     }
 

module/Core/src/ErrorHandler/Model/NotFoundType.php

@@ -13,31 +13,24 @@ use function rtrim;
 
 class NotFoundType
 {
-    private string $type;
-
-    private function __construct(string $type)
+    private function __construct(private string $type)
     {
-        $this->type = $type;
     }
 
     public static function fromRequest(ServerRequestInterface $request, string $basePath): self
     {
-        $isBaseUrl = rtrim($request->getUri()->getPath(), '/') === $basePath;
-        if ($isBaseUrl) {
-            return new self(Visit::TYPE_BASE_URL);
-        }
-
         /** @var RouteResult $routeResult */
         $routeResult = $request->getAttribute(RouteResult::class, RouteResult::fromRouteFailure(null));
-        if ($routeResult->isFailure()) {
-            return new self(Visit::TYPE_REGULAR_404);
-        }
+        $isBaseUrl = rtrim($request->getUri()->getPath(), '/') === $basePath;
 
-        if ($routeResult->getMatchedRouteName() === RedirectAction::class) {
-            return new self(Visit::TYPE_INVALID_SHORT_URL);
-        }
+        $type = match (true) {
+            $isBaseUrl => Visit::TYPE_BASE_URL,
+            $routeResult->isFailure() => Visit::TYPE_REGULAR_404,
+            $routeResult->getMatchedRouteName() === RedirectAction::class => Visit::TYPE_INVALID_SHORT_URL,
+            default => self::class,
+        };
 
-        return new self(self::class);
+        return new self($type);
     }
 
     public function isBaseUrl(): bool

module/Core/src/ErrorHandler/NotFoundRedirectHandler.php

@@ -14,15 +14,10 @@ use Shlinkio\Shlink\Core\Util\RedirectResponseHelperInterface;
 
 class NotFoundRedirectHandler implements MiddlewareInterface
 {
-    private Options\NotFoundRedirectOptions $redirectOptions;
-    private RedirectResponseHelperInterface $redirectResponseHelper;
-
     public function __construct(
-        Options\NotFoundRedirectOptions $redirectOptions,
-        RedirectResponseHelperInterface $redirectResponseHelper
+        private Options\NotFoundRedirectOptions $redirectOptions,
+        private RedirectResponseHelperInterface $redirectResponseHelper
     ) {
-        $this->redirectOptions = $redirectOptions;
-        $this->redirectResponseHelper = $redirectResponseHelper;
     }
 
     public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface

module/Core/src/ErrorHandler/NotFoundTemplateHandler.php

@@ -20,6 +20,7 @@ class NotFoundTemplateHandler implements RequestHandlerInterface
     private const TEMPLATES_BASE_DIR = __DIR__ . '/../../templates';
     public const NOT_FOUND_TEMPLATE = '404.html';
     public const INVALID_SHORT_CODE_TEMPLATE = 'invalid-short-code.html';
+
     private Closure $readFile;
 
     public function __construct(?callable $readFile = null)

module/Core/src/ErrorHandler/NotFoundTrackerMiddleware.php

@@ -14,11 +14,8 @@ use Shlinkio\Shlink\Core\Visit\VisitsTrackerInterface;
 
 class NotFoundTrackerMiddleware implements MiddlewareInterface
 {
-    private VisitsTrackerInterface $visitsTracker;
-
-    public function __construct(VisitsTrackerInterface $visitsTracker)
+    public function __construct(private VisitsTrackerInterface $visitsTracker)
     {
-        $this->visitsTracker = $visitsTracker;
     }
 
     public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface

module/Core/src/ErrorHandler/NotFoundTypeResolverMiddleware.php

@@ -12,11 +12,8 @@ use Shlinkio\Shlink\Core\ErrorHandler\Model\NotFoundType;
 
 class NotFoundTypeResolverMiddleware implements MiddlewareInterface
 {
-    private string $shlinkBasePath;
-
-    public function __construct(string $shlinkBasePath)
+    public function __construct(private string $shlinkBasePath)
     {
-        $this->shlinkBasePath = $shlinkBasePath;
     }
 
     public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface

module/Core/src/EventDispatcher/CloseDbConnectionEventListener.php

@@ -8,13 +8,11 @@ use Shlinkio\Shlink\Common\Doctrine\ReopeningEntityManagerInterface;
 
 class CloseDbConnectionEventListener
 {
-    private ReopeningEntityManagerInterface $em;
     /** @var callable */
     private $wrapped;
 
-    public function __construct(ReopeningEntityManagerInterface $em, callable $wrapped)
+    public function __construct(private ReopeningEntityManagerInterface $em, callable $wrapped)
     {
-        $this->em = $em;
         $this->wrapped = $wrapped;
     }
 

module/Core/src/EventDispatcher/Event/AbstractVisitEvent.php

@@ -8,11 +8,8 @@ use JsonSerializable;
 
 abstract class AbstractVisitEvent implements JsonSerializable
 {
-    protected string $visitId;
-
-    public function __construct(string $visitId)
+    public function __construct(protected string $visitId)
     {
-        $this->visitId = $visitId;
     }
 
     public function visitId(): string

module/Core/src/EventDispatcher/Event/UrlVisited.php

@@ -6,12 +6,9 @@ namespace Shlinkio\Shlink\Core\EventDispatcher\Event;
 
 final class UrlVisited extends AbstractVisitEvent
 {
-    private ?string $originalIpAddress;
-
-    public function __construct(string $visitId, ?string $originalIpAddress = null)
+    public function __construct(string $visitId, private ?string $originalIpAddress = null)
     {
         parent::__construct($visitId);
-        $this->originalIpAddress = $originalIpAddress;
     }
 
     public function originalIpAddress(): ?string

module/Core/src/EventDispatcher/LocateVisit.php

@@ -19,24 +19,13 @@ use Throwable;
 
 class LocateVisit
 {
-    private IpLocationResolverInterface $ipLocationResolver;
-    private EntityManagerInterface $em;
-    private LoggerInterface $logger;
-    private DbUpdaterInterface $dbUpdater;
-    private EventDispatcherInterface $eventDispatcher;
-
     public function __construct(
-        IpLocationResolverInterface $ipLocationResolver,
-        EntityManagerInterface $em,
-        LoggerInterface $logger,
-        DbUpdaterInterface $dbUpdater,
-        EventDispatcherInterface $eventDispatcher
+        private IpLocationResolverInterface $ipLocationResolver,
+        private EntityManagerInterface $em,
+        private LoggerInterface $logger,
+        private DbUpdaterInterface $dbUpdater,
+        private EventDispatcherInterface $eventDispatcher
     ) {
-        $this->ipLocationResolver = $ipLocationResolver;
-        $this->em = $em;
-        $this->logger = $logger;
-        $this->dbUpdater = $dbUpdater;
-        $this->eventDispatcher = $eventDispatcher;
     }
 
     public function __invoke(UrlVisited $shortUrlVisited): void

module/Core/src/EventDispatcher/NotifyVisitToMercure.php

@@ -17,21 +17,12 @@ use function Functional\each;
 
 class NotifyVisitToMercure
 {
-    private HubInterface $hub;
-    private MercureUpdatesGeneratorInterface $updatesGenerator;
-    private EntityManagerInterface $em;
-    private LoggerInterface $logger;
-
     public function __construct(
-        HubInterface $hub,
-        MercureUpdatesGeneratorInterface $updatesGenerator,
-        EntityManagerInterface $em,
-        LoggerInterface $logger
+        private HubInterface $hub,
+        private MercureUpdatesGeneratorInterface $updatesGenerator,
+        private EntityManagerInterface $em,
+        private LoggerInterface $logger
     ) {
-        $this->hub = $hub;
-        $this->em = $em;
-        $this->logger = $logger;
-        $this->updatesGenerator = $updatesGenerator;
     }
 
     public function __invoke(VisitLocated $shortUrlLocated): void

module/Core/src/EventDispatcher/NotifyVisitToWebHooks.php

@@ -24,28 +24,15 @@ use function Functional\partial_left;
 
 class NotifyVisitToWebHooks
 {
-    private ClientInterface $httpClient;
-    private EntityManagerInterface $em;
-    private LoggerInterface $logger;
-    /** @var string[] */
-    private array $webhooks;
-    private DataTransformerInterface $transformer;
-    private AppOptions $appOptions;
-
     public function __construct(
-        ClientInterface $httpClient,
-        EntityManagerInterface $em,
-        LoggerInterface $logger,
-        array $webhooks,
-        DataTransformerInterface $transformer,
-        AppOptions $appOptions
+        private ClientInterface $httpClient,
+        private EntityManagerInterface $em,
+        private LoggerInterface $logger,
+        /** @var string[] */
+        private array $webhooks,
+        private DataTransformerInterface $transformer,
+        private AppOptions $appOptions
     ) {
-        $this->httpClient = $httpClient;
-        $this->em = $em;
-        $this->logger = $logger;
-        $this->webhooks = $webhooks;
-        $this->transformer = $transformer;
-        $this->appOptions = $appOptions;
     }
 
     public function __invoke(VisitLocated $shortUrlLocated): void

module/Core/src/EventDispatcher/UpdateGeoLiteDb.php

@@ -12,13 +12,8 @@ use function sprintf;
 
 class UpdateGeoLiteDb
 {
-    private GeolocationDbUpdaterInterface $dbUpdater;
-    private LoggerInterface $logger;
-
-    public function __construct(GeolocationDbUpdaterInterface $dbUpdater, LoggerInterface $logger)
+    public function __construct(private GeolocationDbUpdaterInterface $dbUpdater, private LoggerInterface $logger)
     {
-        $this->dbUpdater = $dbUpdater;
-        $this->logger = $logger;
     }
 
     public function __invoke(): void

module/Core/src/Importer/ImportedLinksProcessor.php

@@ -20,22 +20,14 @@ use function sprintf;
 
 class ImportedLinksProcessor implements ImportedLinksProcessorInterface
 {
-    private EntityManagerInterface $em;
-    private ShortUrlRelationResolverInterface $relationResolver;
-    private ShortCodeHelperInterface $shortCodeHelper;
-    private DoctrineBatchHelperInterface $batchHelper;
     private ShortUrlRepositoryInterface $shortUrlRepo;
 
     public function __construct(
-        EntityManagerInterface $em,
-        ShortUrlRelationResolverInterface $relationResolver,
-        ShortCodeHelperInterface $shortCodeHelper,
-        DoctrineBatchHelperInterface $batchHelper
+        private EntityManagerInterface $em,
+        private ShortUrlRelationResolverInterface $relationResolver,
+        private ShortCodeHelperInterface $shortCodeHelper,
+        private DoctrineBatchHelperInterface $batchHelper
     ) {
-        $this->em = $em;
-        $this->relationResolver = $relationResolver;
-        $this->shortCodeHelper = $shortCodeHelper;
-        $this->batchHelper = $batchHelper;
         $this->shortUrlRepo = $this->em->getRepository(ShortUrl::class); // @phpstan-ignore-line
     }
 
@@ -64,7 +56,7 @@ class ImportedLinksProcessor implements ImportedLinksProcessorInterface
 
             try {
                 $shortUrlImporting = $this->resolveShortUrl($importedUrl, $importShortCodes, $skipOnShortCodeConflict);
-            } catch (NonUniqueSlugException $e) {
+            } catch (NonUniqueSlugException) {
                 $io->text(sprintf('%s: <fg=red>Error</>', $longUrl));
                 continue;
             }

module/Core/src/Importer/ShortUrlImporting.php

@@ -14,13 +14,8 @@ use function sprintf;
 
 final class ShortUrlImporting
 {
-    private ShortUrl $shortUrl;
-    private bool $isNew;
-
-    private function __construct(ShortUrl $shortUrl, bool $isNew)
+    private function __construct(private ShortUrl $shortUrl, private bool $isNew)
     {
-        $this->shortUrl = $shortUrl;
-        $this->isNew = $isNew;
     }
 
     public static function fromExistingShortUrl(ShortUrl $shortUrl): self

module/Core/src/Mercure/MercureUpdatesGenerator.php

@@ -18,15 +18,10 @@ final class MercureUpdatesGenerator implements MercureUpdatesGeneratorInterface
     private const NEW_VISIT_TOPIC = 'https://shlink.io/new-visit';
     private const NEW_ORPHAN_VISIT_TOPIC = 'https://shlink.io/new-orphan-visit';
 
-    private DataTransformerInterface $shortUrlTransformer;
-    private DataTransformerInterface $orphanVisitTransformer;
-
     public function __construct(
-        DataTransformerInterface $shortUrlTransformer,
-        DataTransformerInterface $orphanVisitTransformer
+        private DataTransformerInterface $shortUrlTransformer,
+        private DataTransformerInterface $orphanVisitTransformer
     ) {
-        $this->shortUrlTransformer = $shortUrlTransformer;
-        $this->orphanVisitTransformer = $orphanVisitTransformer;
     }
 
     public function newVisitUpdate(Visit $visit): Update

module/Core/src/Model/ShortUrlIdentifier.php

@@ -10,13 +10,8 @@ use Symfony\Component\Console\Input\InputInterface;
 
 final class ShortUrlIdentifier
 {
-    private string $shortCode;
-    private ?string $domain;
-
-    public function __construct(string $shortCode, ?string $domain = null)
+    public function __construct(private string $shortCode, private ?string $domain = null)
     {
-        $this->shortCode = $shortCode;
-        $this->domain = $domain;
     }
 
     public static function fromApiRequest(ServerRequestInterface $request): self

module/Core/src/Model/VisitsParams.php

@@ -14,20 +14,16 @@ final class VisitsParams
     private const ALL_ITEMS = -1;
 
     private ?DateRange $dateRange;
-    private int $page;
     private int $itemsPerPage;
-    private bool $excludeBots;
 
     public function __construct(
         ?DateRange $dateRange = null,
-        int $page = self::FIRST_PAGE,
+        private int $page = self::FIRST_PAGE,
         ?int $itemsPerPage = null,
-        bool $excludeBots = false
+        private bool $excludeBots = false
     ) {
         $this->dateRange = $dateRange ?? new DateRange();
-        $this->page = $page;
         $this->itemsPerPage = $this->determineItemsPerPage($itemsPerPage);
-        $this->excludeBots = $excludeBots;
     }
 
     private function determineItemsPerPage(?int $itemsPerPage): int

module/Core/src/Paginator/Adapter/OrphanVisitsPaginatorAdapter.php

@@ -11,13 +11,8 @@ use Shlinkio\Shlink\Core\Visit\Persistence\VisitsListFiltering;
 
 class OrphanVisitsPaginatorAdapter extends AbstractCacheableCountPaginatorAdapter
 {
-    private VisitRepositoryInterface $repo;
-    private VisitsParams $params;
-
-    public function __construct(VisitRepositoryInterface $repo, VisitsParams $params)
+    public function __construct(private VisitRepositoryInterface $repo, private VisitsParams $params)
     {
-        $this->repo = $repo;
-        $this->params = $params;
     }
 
     protected function doCount(): int

module/Core/src/Paginator/Adapter/ShortUrlRepositoryAdapter.php

@@ -12,15 +12,11 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class ShortUrlRepositoryAdapter implements AdapterInterface
 {
-    private ShortUrlRepositoryInterface $repository;
-    private ShortUrlsParams $params;
-    private ?ApiKey $apiKey;
-
-    public function __construct(ShortUrlRepositoryInterface $repository, ShortUrlsParams $params, ?ApiKey $apiKey)
-    {
-        $this->repository = $repository;
-        $this->params = $params;
-        $this->apiKey = $apiKey;
+    public function __construct(
+        private ShortUrlRepositoryInterface $repository,
+        private ShortUrlsParams $params,
+        private ?ApiKey $apiKey
+    ) {
     }
 
     public function getSlice($offset, $length): array // phpcs:ignore

module/Core/src/Paginator/Adapter/VisitsForTagPaginatorAdapter.php

@@ -13,21 +13,12 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class VisitsForTagPaginatorAdapter extends AbstractCacheableCountPaginatorAdapter
 {
-    private VisitRepositoryInterface $visitRepository;
-    private string $tag;
-    private VisitsParams $params;
-    private ?ApiKey $apiKey;
-
     public function __construct(
-        VisitRepositoryInterface $visitRepository,
-        string $tag,
-        VisitsParams $params,
-        ?ApiKey $apiKey
+        private VisitRepositoryInterface $visitRepository,
+        private string $tag,
+        private VisitsParams $params,
+        private ?ApiKey $apiKey
     ) {
-        $this->visitRepository = $visitRepository;
-        $this->params = $params;
-        $this->tag = $tag;
-        $this->apiKey = $apiKey;
     }
 
     public function getSlice($offset, $length): array // phpcs:ignore

module/Core/src/Paginator/Adapter/VisitsPaginatorAdapter.php

@@ -13,21 +13,12 @@ use Shlinkio\Shlink\Core\Visit\Persistence\VisitsListFiltering;
 
 class VisitsPaginatorAdapter extends AbstractCacheableCountPaginatorAdapter
 {
-    private VisitRepositoryInterface $visitRepository;
-    private ShortUrlIdentifier $identifier;
-    private VisitsParams $params;
-    private ?Specification $spec;
-
     public function __construct(
-        VisitRepositoryInterface $visitRepository,
-        ShortUrlIdentifier $identifier,
-        VisitsParams $params,
-        ?Specification $spec
+        private VisitRepositoryInterface $visitRepository,
+        private ShortUrlIdentifier $identifier,
+        private VisitsParams $params,
+        private ?Specification $spec
     ) {
-        $this->visitRepository = $visitRepository;
-        $this->params = $params;
-        $this->identifier = $identifier;
-        $this->spec = $spec;
     }
 
     public function getSlice($offset, $length): array // phpcs:ignore

module/Core/src/Service/ShortUrl/DeleteShortUrlService.php

@@ -13,18 +13,11 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class DeleteShortUrlService implements DeleteShortUrlServiceInterface
 {
-    private EntityManagerInterface $em;
-    private DeleteShortUrlsOptions $deleteShortUrlsOptions;
-    private ShortUrlResolverInterface $urlResolver;
-
     public function __construct(
-        EntityManagerInterface $em,
-        DeleteShortUrlsOptions $deleteShortUrlsOptions,
-        ShortUrlResolverInterface $urlResolver
+        private EntityManagerInterface $em,
+        private DeleteShortUrlsOptions $deleteShortUrlsOptions,
+        private ShortUrlResolverInterface $urlResolver
     ) {
-        $this->em = $em;
-        $this->deleteShortUrlsOptions = $deleteShortUrlsOptions;
-        $this->urlResolver = $urlResolver;
     }
 
     /**

module/Core/src/Service/ShortUrl/ShortCodeHelper.php

@@ -11,11 +11,8 @@ use Shlinkio\Shlink\Core\Repository\ShortUrlRepository;
 
 class ShortCodeHelper implements ShortCodeHelperInterface // TODO Rename to ShortCodeUniquenessHelper
 {
-    private EntityManagerInterface $em;
-
-    public function __construct(EntityManagerInterface $em)
+    public function __construct(private EntityManagerInterface $em)
     {
-        $this->em = $em;
     }
 
     public function ensureShortCodeUniqueness(ShortUrl $shortUrlToBeCreated, bool $hasCustomSlug): bool

module/Core/src/Service/ShortUrl/ShortUrlResolver.php

@@ -13,11 +13,8 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class ShortUrlResolver implements ShortUrlResolverInterface
 {
-    private EntityManagerInterface $em;
-
-    public function __construct(EntityManagerInterface $em)
+    public function __construct(private EntityManagerInterface $em)
     {
-        $this->em = $em;
     }
 
     /**

module/Core/src/Service/ShortUrlService.php

@@ -21,21 +21,12 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class ShortUrlService implements ShortUrlServiceInterface
 {
-    private ORM\EntityManagerInterface $em;
-    private ShortUrlResolverInterface $urlResolver;
-    private ShortUrlTitleResolutionHelperInterface $titleResolutionHelper;
-    private ShortUrlRelationResolverInterface $relationResolver;
-
     public function __construct(
-        ORM\EntityManagerInterface $em,
-        ShortUrlResolverInterface $urlResolver,
-        ShortUrlTitleResolutionHelperInterface $titleResolutionHelper,
-        ShortUrlRelationResolverInterface $relationResolver
+        private ORM\EntityManagerInterface $em,
+        private ShortUrlResolverInterface $urlResolver,
+        private ShortUrlTitleResolutionHelperInterface $titleResolutionHelper,
+        private ShortUrlRelationResolverInterface $relationResolver
     ) {
-        $this->em = $em;
-        $this->urlResolver = $urlResolver;
-        $this->titleResolutionHelper = $titleResolutionHelper;
-        $this->relationResolver = $relationResolver;
     }
 
     /**

module/Core/src/Service/UrlShortener.php

@@ -16,21 +16,12 @@ use Shlinkio\Shlink\Core\ShortUrl\Resolver\ShortUrlRelationResolverInterface;
 
 class UrlShortener implements UrlShortenerInterface
 {
-    private EntityManagerInterface $em;
-    private ShortUrlTitleResolutionHelperInterface $titleResolutionHelper;
-    private ShortUrlRelationResolverInterface $relationResolver;
-    private ShortCodeHelperInterface $shortCodeHelper;
-
     public function __construct(
-        ShortUrlTitleResolutionHelperInterface $titleResolutionHelper,
-        EntityManagerInterface $em,
-        ShortUrlRelationResolverInterface $relationResolver,
-        ShortCodeHelperInterface $shortCodeHelper
+        private ShortUrlTitleResolutionHelperInterface $titleResolutionHelper,
+        private EntityManagerInterface $em,
+        private ShortUrlRelationResolverInterface $relationResolver,
+        private ShortCodeHelperInterface $shortCodeHelper
     ) {
-        $this->titleResolutionHelper = $titleResolutionHelper;
-        $this->em = $em;
-        $this->relationResolver = $relationResolver;
-        $this->shortCodeHelper = $shortCodeHelper;
     }
 
     /**

module/Core/src/ShortUrl/Helper/ShortUrlStringifier.php

@@ -11,13 +11,8 @@ use function sprintf;
 
 class ShortUrlStringifier implements ShortUrlStringifierInterface
 {
-    private array $domainConfig;
-    private string $basePath;
-
-    public function __construct(array $domainConfig, string $basePath = '')
+    public function __construct(private array $domainConfig, private string $basePath = '')
     {
-        $this->domainConfig = $domainConfig;
-        $this->basePath = $basePath;
     }
 
     public function stringify(ShortUrl $shortUrl): string

module/Core/src/ShortUrl/Helper/ShortUrlTitleResolutionHelper.php

@@ -8,11 +8,8 @@ use Shlinkio\Shlink\Core\Util\UrlValidatorInterface;
 
 class ShortUrlTitleResolutionHelper implements ShortUrlTitleResolutionHelperInterface
 {
-    private UrlValidatorInterface $urlValidator;
-
-    public function __construct(UrlValidatorInterface $urlValidator)
+    public function __construct(private UrlValidatorInterface $urlValidator)
     {
-        $this->urlValidator = $urlValidator;
     }
 
     public function processTitleAndValidateUrl(TitleResolutionModelInterface $data): TitleResolutionModelInterface

module/Core/src/ShortUrl/Resolver/PersistenceShortUrlRelationResolver.php

@@ -16,16 +16,13 @@ use function Functional\unique;
 
 class PersistenceShortUrlRelationResolver implements ShortUrlRelationResolverInterface
 {
-    private EntityManagerInterface $em;
-
     /** @var array<string, Domain> */
     private array $memoizedNewDomains = [];
     /** @var array<string, Tag> */
     private array $memoizedNewTags = [];
 
-    public function __construct(EntityManagerInterface $em)
+    public function __construct(private EntityManagerInterface $em)
     {
-        $this->em = $em;
         $this->em->getEventManager()->addEventListener(Events::postFlush, $this);
     }
 

module/Core/src/ShortUrl/Spec/BelongsToApiKey.php

@@ -11,13 +11,8 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class BelongsToApiKey extends BaseSpecification
 {
-    private ApiKey $apiKey;
-    private ?string $dqlAlias;
-
-    public function __construct(ApiKey $apiKey, ?string $dqlAlias = null)
+    public function __construct(private ApiKey $apiKey, private ?string $dqlAlias = null)
     {
-        $this->apiKey = $apiKey;
-        $this->dqlAlias = $dqlAlias;
         parent::__construct();
     }
 

module/Core/src/ShortUrl/Spec/BelongsToApiKeyInlined.php

@@ -10,11 +10,8 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class BelongsToApiKeyInlined implements Filter
 {
-    private ApiKey $apiKey;
-
-    public function __construct(ApiKey $apiKey)
+    public function __construct(private ApiKey $apiKey)
     {
-        $this->apiKey = $apiKey;
     }
 
     public function getFilter(QueryBuilder $qb, string $dqlAlias): string

module/Core/src/ShortUrl/Spec/BelongsToDomain.php

@@ -10,13 +10,8 @@ use Happyr\DoctrineSpecification\Specification\BaseSpecification;
 
 class BelongsToDomain extends BaseSpecification
 {
-    private string $domainId;
-    private ?string $dqlAlias;
-
-    public function __construct(string $domainId, ?string $dqlAlias = null)
+    public function __construct(private string $domainId, private ?string $dqlAlias = null)
     {
-        $this->domainId = $domainId;
-        $this->dqlAlias = $dqlAlias;
         parent::__construct();
     }
 

module/Core/src/ShortUrl/Spec/BelongsToDomainInlined.php

@@ -9,11 +9,8 @@ use Happyr\DoctrineSpecification\Filter\Filter;
 
 class BelongsToDomainInlined implements Filter
 {
-    private string $domainId;
-
-    public function __construct(string $domainId)
+    public function __construct(private string $domainId)
     {
-        $this->domainId = $domainId;
     }
 
     public function getFilter(QueryBuilder $qb, string $dqlAlias): string

module/Core/src/ShortUrl/Transformer/ShortUrlDataTransformer.php

@@ -13,11 +13,8 @@ use function Functional\invoke_if;
 
 class ShortUrlDataTransformer implements DataTransformerInterface
 {
-    private ShortUrlStringifierInterface $stringifier;
-
-    public function __construct(ShortUrlStringifierInterface $stringifier)
+    public function __construct(private ShortUrlStringifierInterface $stringifier)
     {
-        $this->stringifier = $stringifier;
     }
 
     /**

module/Core/src/Spec/InDateRange.php

@@ -11,14 +11,9 @@ use Shlinkio\Shlink\Common\Util\DateRange;
 
 class InDateRange extends BaseSpecification
 {
-    private ?DateRange $dateRange;
-    private string $field;
-
-    public function __construct(?DateRange $dateRange, string $field = 'date')
+    public function __construct(private ?DateRange $dateRange, private string $field = 'date')
     {
         parent::__construct();
-        $this->dateRange = $dateRange;
-        $this->field = $field;
     }
 
     protected function getSpec(): Specification

module/Core/src/Tag/Model/TagInfo.php

@@ -9,15 +9,8 @@ use Shlinkio\Shlink\Core\Entity\Tag;
 
 final class TagInfo implements JsonSerializable
 {
-    private Tag $tag;
-    private int $shortUrlsCount;
-    private int $visitsCount;
-
-    public function __construct(Tag $tag, int $shortUrlsCount, int $visitsCount)
+    public function __construct(private Tag $tag, private int $shortUrlsCount, private int $visitsCount)
     {
-        $this->tag = $tag;
-        $this->shortUrlsCount = $shortUrlsCount;
-        $this->visitsCount = $visitsCount;
     }
 
     public function tag(): Tag

module/Core/src/Tag/Spec/CountTagsWithName.php

@@ -10,12 +10,9 @@ use Happyr\DoctrineSpecification\Specification\Specification;
 
 class CountTagsWithName extends BaseSpecification
 {
-    private string $tagName;
-
-    public function __construct(string $tagName)
+    public function __construct(private string $tagName)
     {
         parent::__construct();
-        $this->tagName = $tagName;
     }
 
     protected function getSpec(): Specification

module/Core/src/Tag/TagService.php

@@ -23,11 +23,8 @@ class TagService implements TagServiceInterface
 {
     use TagManagerTrait;
 
-    private ORM\EntityManagerInterface $em;
-
-    public function __construct(ORM\EntityManagerInterface $em)
+    public function __construct(private ORM\EntityManagerInterface $em)
     {
-        $this->em = $em;
     }
 
     /**

module/Core/src/Util/CocurSymfonySluggerBridge.php

@@ -12,11 +12,8 @@ use function Symfony\Component\String\s;
 
 class CocurSymfonySluggerBridge implements SluggerInterface
 {
-    private SlugifyInterface $slugger;
-
-    public function __construct(SlugifyInterface $slugger)
+    public function __construct(private SlugifyInterface $slugger)
     {
-        $this->slugger = $slugger;
     }
 
     public function slug(string $string, string $separator = '-', ?string $locale = null): AbstractUnicodeString

module/Core/src/Util/DoctrineBatchHelper.php

@@ -12,11 +12,8 @@ use Throwable;
  */
 class DoctrineBatchHelper implements DoctrineBatchHelperInterface
 {
-    private EntityManagerInterface $em;
-
-    public function __construct(EntityManagerInterface $em)
+    public function __construct(private EntityManagerInterface $em)
     {
-        $this->em = $em;
     }
 
     /**

module/Core/src/Util/RedirectResponseHelper.php

@@ -13,11 +13,8 @@ use function sprintf;
 
 class RedirectResponseHelper implements RedirectResponseHelperInterface
 {
-    private UrlShortenerOptions $options;
-
-    public function __construct(UrlShortenerOptions $options)
+    public function __construct(private UrlShortenerOptions $options)
     {
-        $this->options = $options;
     }
 
     public function buildRedirectResponse(string $location): ResponseInterface

module/Core/src/Util/UrlValidator.php

@@ -23,13 +23,8 @@ class UrlValidator implements UrlValidatorInterface, RequestMethodInterface
     private const CHROME_USER_AGENT = 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) '
         . 'Chrome/51.0.2704.103 Safari/537.36';
 
-    private ClientInterface $httpClient;
-    private UrlShortenerOptions $options;
-
-    public function __construct(ClientInterface $httpClient, UrlShortenerOptions $options)
+    public function __construct(private ClientInterface $httpClient, private UrlShortenerOptions $options)
     {
-        $this->httpClient = $httpClient;
-        $this->options = $options;
     }
 
     /**

module/Core/src/Visit/Model/VisitsStats.php

@@ -8,13 +8,8 @@ use JsonSerializable;
 
 final class VisitsStats implements JsonSerializable
 {
-    private int $visitsCount;
-    private int $orphanVisitsCount;
-
-    public function __construct(int $visitsCount, int $orphanVisitsCount)
+    public function __construct(private int $visitsCount, private int $orphanVisitsCount)
     {
-        $this->visitsCount = $visitsCount;
-        $this->orphanVisitsCount = $orphanVisitsCount;
     }
 
     public function jsonSerialize(): array

module/Core/src/Visit/Persistence/VisitsCountFiltering.php

@@ -9,15 +9,11 @@ use Shlinkio\Shlink\Common\Util\DateRange;
 
 class VisitsCountFiltering
 {
-    private ?DateRange $dateRange;
-    private bool $excludeBots;
-    private ?Specification $spec;
-
-    public function __construct(?DateRange $dateRange = null, bool $excludeBots = false, ?Specification $spec = null)
-    {
-        $this->dateRange = $dateRange;
-        $this->excludeBots = $excludeBots;
-        $this->spec = $spec;
+    public function __construct(
+        private ?DateRange $dateRange = null,
+        private bool $excludeBots = false,
+        private ?Specification $spec = null
+    ) {
     }
 
     public function dateRange(): ?DateRange

module/Core/src/Visit/Persistence/VisitsListFiltering.php

@@ -9,19 +9,14 @@ use Shlinkio\Shlink\Common\Util\DateRange;
 
 final class VisitsListFiltering extends VisitsCountFiltering
 {
-    private ?int $limit;
-    private ?int $offset;
-
     public function __construct(
         ?DateRange $dateRange = null,
         bool $excludeBots = false,
         ?Specification $spec = null,
-        ?int $limit = null,
-        ?int $offset = null
+        private ?int $limit = null,
+        private ?int $offset = null
     ) {
         parent::__construct($dateRange, $excludeBots, $spec);
-        $this->limit = $limit;
-        $this->offset = $offset;
     }
 
     public function limit(): ?int

module/Core/src/Visit/Spec/CountOfOrphanVisits.php

@@ -12,12 +12,9 @@ use Shlinkio\Shlink\Core\Visit\Persistence\VisitsCountFiltering;
 
 class CountOfOrphanVisits extends BaseSpecification
 {
-    private VisitsCountFiltering $filtering;
-
-    public function __construct(VisitsCountFiltering $filtering)
+    public function __construct(private VisitsCountFiltering $filtering)
     {
         parent::__construct();
-        $this->filtering = $filtering;
     }
 
     protected function getSpec(): Specification

module/Core/src/Visit/Spec/CountOfShortUrlVisits.php

@@ -12,12 +12,9 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class CountOfShortUrlVisits extends BaseSpecification
 {
-    private ?ApiKey $apiKey;
-
-    public function __construct(?ApiKey $apiKey)
+    public function __construct(private ?ApiKey $apiKey)
     {
         parent::__construct();
-        $this->apiKey = $apiKey;
     }
 
     protected function getSpec(): Specification

module/Core/src/Visit/VisitLocator.php

@@ -13,13 +13,10 @@ use Shlinkio\Shlink\IpGeolocation\Model\Location;
 
 class VisitLocator implements VisitLocatorInterface
 {
-    private EntityManagerInterface $em;
     private VisitRepositoryInterface $repo;
 
-    public function __construct(EntityManagerInterface $em)
+    public function __construct(private EntityManagerInterface $em)
     {
-        $this->em = $em;
-
         /** @var VisitRepositoryInterface $repo */
         $repo = $em->getRepository(Visit::class);
         $this->repo = $repo;

module/Core/src/Visit/VisitsStatsHelper.php

@@ -27,11 +27,8 @@ use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
 class VisitsStatsHelper implements VisitsStatsHelperInterface
 {
-    private EntityManagerInterface $em;
-
-    public function __construct(EntityManagerInterface $em)
+    public function __construct(private EntityManagerInterface $em)
     {
-        $this->em = $em;
     }
 
     public function getVisitsStats(?ApiKey $apiKey = null): VisitsStats

module/Core/src/Visit/VisitsTracker.php

@@ -14,18 +14,11 @@ use Shlinkio\Shlink\Core\Options\TrackingOptions;
 
 class VisitsTracker implements VisitsTrackerInterface
 {
-    private ORM\EntityManagerInterface $em;
-    private EventDispatcherInterface $eventDispatcher;
-    private TrackingOptions $options;
-
     public function __construct(
-        ORM\EntityManagerInterface $em,
-        EventDispatcherInterface $eventDispatcher,
-        TrackingOptions $options
+        private ORM\EntityManagerInterface $em,
+        private EventDispatcherInterface $eventDispatcher,
+        private TrackingOptions $options
     ) {
-        $this->em = $em;
-        $this->eventDispatcher = $eventDispatcher;
-        $this->options = $options;
     }
 
     public function track(ShortUrl $shortUrl, Visitor $visitor): void

module/Core/test-db/Domain/Repository/DomainRepositoryTest.php

@@ -94,11 +94,8 @@ class DomainRepositoryTest extends DatabaseTestCase
         return ShortUrl::fromMeta(
             ShortUrlMeta::fromRawData(['domain' => $domain->getAuthority(), 'apiKey' => $apiKey, 'longUrl' => 'foo']),
             new class ($domain) implements ShortUrlRelationResolverInterface {
-                private Domain $domain;
-
-                public function __construct(Domain $domain)
+                public function __construct(private Domain $domain)
                 {
-                    $this->domain = $domain;
                 }
 
                 public function resolveDomain(?string $domain): ?Domain

module/Core/test/Visit/VisitLocatorTest.php

@@ -122,11 +122,8 @@ class VisitLocatorTest extends TestCase
 
         $this->visitService->{$serviceMethodName}(
             new class ($isNonLocatableAddress) implements VisitGeolocationHelperInterface {
-                private bool $isNonLocatableAddress;
-
-                public function __construct(bool $isNonLocatableAddress)
+                public function __construct(private bool $isNonLocatableAddress)
                 {
-                    $this->isNonLocatableAddress = $isNonLocatableAddress;
                 }
 
                 public function geolocateVisit(Visit $visit): Location