Mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2026-03-10 01:03:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Be less restrictive on what characters are disallowed in custom slugs

Browse Source
This commit is contained in:
Alejandro Celaya
2024-12-17 18:00:02 +01:00
parent d533adf7ce
commit e80af78e09
3 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
module/Core/src/ShortUrl/Model/Validation/CustomSlugValidator.php
View File

@@ -46,10 +46,10 @@ class CustomSlugValidator extends AbstractValidator
return false;
}
// URL reserved characters: https://datatracker.ietf.org/doc/html/rfc3986#section-2.2
$reservedChars = "!*'();:@&=+$,?%#[]";
// URL gen-delimiter reserved characters, except `/`: https://datatracker.ietf.org/doc/html/rfc3986#section-2.2
$reservedChars = ':?#[]@';
if (! $this->options->multiSegmentSlugsEnabled) {
// Slashes should be allowed for multi-segment slugs
// Slashes should only be allowed if multi-segment slugs are enabled
$reservedChars .= '/';
}

6
module/Core/test/ShortUrl/Model/Validation/CustomSlugValidatorTest.php
View File

@@ -59,13 +59,11 @@ class CustomSlugValidatorTest extends TestCase
public static function provideInvalidValues(): iterable
{
yield ['port:8080'];
yield ['foo?bar=baz'];
yield ['some-thing#foo'];
yield ['call()'];
yield ['array[]'];
yield ['brackets[]'];
yield ['email@example.com'];
yield ['wildcard*'];
yield ['$500'];
}
public function createValidator(bool $multiSegmentSlugsEnabled = false): CustomSlugValidator