Changed behavior of domains list so that it does not return configured redirects as redirects for default domain

module/Core/src/Config/EmptyNotFoundRedirectConfig.php

@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Shlinkio\Shlink\Core\Config;
+
+final class EmptyNotFoundRedirectConfig implements NotFoundRedirectConfigInterface
+{
+    public function invalidShortUrlRedirect(): ?string
+    {
+        return null;
+    }
+
+    public function hasInvalidShortUrlRedirect(): bool
+    {
+        return false;
+    }
+
+    public function regular404Redirect(): ?string
+    {
+        return null;
+    }
+
+    public function hasRegular404Redirect(): bool
+    {
+        return false;
+    }
+
+    public function baseUrlRedirect(): ?string
+    {
+        return null;
+    }
+
+    public function hasBaseUrlRedirect(): bool
+    {
+        return false;
+    }
+}

module/Core/src/Domain/DomainService.php

@@ -5,12 +5,12 @@ declare(strict_types=1);
 namespace Shlinkio\Shlink\Core\Domain;
 
 use Doctrine\ORM\EntityManagerInterface;
+use Shlinkio\Shlink\Core\Config\EmptyNotFoundRedirectConfig;
 use Shlinkio\Shlink\Core\Config\NotFoundRedirects;
 use Shlinkio\Shlink\Core\Domain\Model\DomainItem;
 use Shlinkio\Shlink\Core\Domain\Repository\DomainRepositoryInterface;
 use Shlinkio\Shlink\Core\Entity\Domain;
 use Shlinkio\Shlink\Core\Exception\DomainNotFoundException;
-use Shlinkio\Shlink\Core\Options\NotFoundRedirectOptions;
 use Shlinkio\Shlink\Rest\ApiKey\Role;
 use Shlinkio\Shlink\Rest\Entity\ApiKey;
 
@@ -20,11 +20,8 @@ use function Functional\map;
 
 class DomainService implements DomainServiceInterface
 {
-    public function __construct(
-        private EntityManagerInterface $em,
-        private string $defaultDomain,
-        private NotFoundRedirectOptions $redirectOptions,
-    ) {
+    public function __construct(private EntityManagerInterface $em, private string $defaultDomain)
+    {
     }
 
     /**
@@ -33,14 +30,14 @@ class DomainService implements DomainServiceInterface
     public function listDomains(?ApiKey $apiKey = null): array
     {
         [$default, $domains] = $this->defaultDomainAndRest($apiKey);
-        $mappedDomains = map($domains, fn (Domain $domain) => DomainItem::forExistingDomain($domain));
+        $mappedDomains = map($domains, fn (Domain $domain) => DomainItem::forNonDefaultDomain($domain));
 
         if ($apiKey?->hasRole(Role::DOMAIN_SPECIFIC)) {
             return $mappedDomains;
         }
 
         return [
-            DomainItem::forDefaultDomain($this->defaultDomain, $default ?? $this->redirectOptions),
+            DomainItem::forDefaultDomain($this->defaultDomain, $default ?? new EmptyNotFoundRedirectConfig()),
             ...$mappedDomains,
         ];
     }

module/Core/src/Domain/Model/DomainItem.php

@@ -18,7 +18,7 @@ final class DomainItem implements JsonSerializable
     ) {
     }
 
-    public static function forExistingDomain(Domain $domain): self
+    public static function forNonDefaultDomain(Domain $domain): self
     {
         return new self($domain->getAuthority(), $domain, false);
     }

module/Core/src/Options/NotFoundRedirectOptions.php

@@ -4,11 +4,10 @@ declare(strict_types=1);
 
 namespace Shlinkio\Shlink\Core\Options;
 
-use JsonSerializable;
 use Laminas\Stdlib\AbstractOptions;
 use Shlinkio\Shlink\Core\Config\NotFoundRedirectConfigInterface;
 
-class NotFoundRedirectOptions extends AbstractOptions implements NotFoundRedirectConfigInterface, JsonSerializable
+class NotFoundRedirectOptions extends AbstractOptions implements NotFoundRedirectConfigInterface
 {
     private ?string $invalidShortUrl = null;
     private ?string $regular404 = null;
@@ -61,13 +60,4 @@ class NotFoundRedirectOptions extends AbstractOptions implements NotFoundRedirec
         $this->baseUrl = $baseUrl;
         return $this;
     }
-
-    public function jsonSerialize(): array
-    {
-        return [
-            'baseUrlRedirect' => $this->baseUrl,
-            'regular404Redirect' => $this->regular404,
-            'invalidShortUrlRedirect' => $this->invalidShortUrl,
-        ];
-    }
 }