From f3ff059d486380f0c3b731da54ae5172aad35778 Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Mon, 17 Nov 2025 12:33:08 +0100 Subject: [PATCH] Improve RoleResolver coverage --- module/CLI/test/ApiKey/RoleResolverTest.php | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/module/CLI/test/ApiKey/RoleResolverTest.php b/module/CLI/test/ApiKey/RoleResolverTest.php index 184780d7..ac47a262 100644 --- a/module/CLI/test/ApiKey/RoleResolverTest.php +++ b/module/CLI/test/ApiKey/RoleResolverTest.php @@ -91,11 +91,17 @@ class RoleResolverTest extends TestCase [RoleDefinition::forAuthoredShortUrls()], 0, ]; - yield 'both roles' => [ - $buildInput( - [Role::DOMAIN_SPECIFIC->paramName() => 'example.com', Role::AUTHORED_SHORT_URLS->paramName() => true], - ), - [RoleDefinition::forAuthoredShortUrls(), RoleDefinition::forDomain($domain)], + yield 'all roles' => [ + $buildInput([ + Role::DOMAIN_SPECIFIC->paramName() => 'example.com', + Role::AUTHORED_SHORT_URLS->paramName() => true, + Role::NO_ORPHAN_VISITS->paramName() => true, + ]), + [ + RoleDefinition::forAuthoredShortUrls(), + RoleDefinition::forDomain($domain), + RoleDefinition::forNoOrphanVisits(), + ], 1, ]; }