Mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2026-03-06 15:23:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Added more tests covering invalid custom slugs

Browse Source
This commit is contained in:
Alejandro Celaya
2020-03-06 20:01:41 +01:00
parent 18ceafeb60
commit f5c1e12db4
4 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
module/Core/src/Validation/ShortUrlMetaInputFilter.php
View File

@@ -44,7 +44,10 @@ class ShortUrlMetaInputFilter extends InputFilter
// empty, is by using the deprecated setContinueIfEmpty
$customSlug = $this->createInput(self::CUSTOM_SLUG, false)->setContinueIfEmpty(true);
$customSlug->getFilterChain()->attach(new Validation\SluggerFilter());
$customSlug->getValidatorChain()->attach(new Validator\NotEmpty(Validator\NotEmpty::STRING));
$customSlug->getValidatorChain()->attach(new Validator\NotEmpty([
Validator\NotEmpty::STRING,
Validator\NotEmpty::SPACE,
]));
$this->add($customSlug);
$this->add($this->createPositiveNumberInput(self::MAX_VISITS));

9
module/Core/test/Model/ShortUrlMetaTest.php
View File

@@ -47,6 +47,15 @@ class ShortUrlMetaTest extends TestCase
yield [[
ShortUrlMetaInputFilter::SHORT_CODE_LENGTH => 3,
]];
yield [[
ShortUrlMetaInputFilter::CUSTOM_SLUG => '/',
]];
yield [[
ShortUrlMetaInputFilter::CUSTOM_SLUG => '',
]];
yield [[
ShortUrlMetaInputFilter::CUSTOM_SLUG => ' ',
]];
}
/** @test */