Renamed GenerateShortUrlCommand to CreateShortUrlCommand

2026-02-28 04:03:12 +08:00 · 2021-12-09 09:45:15 +01:00
parent 8cc4e4bfca
commit f8a48c16f0
4 changed files with 9 additions and 8 deletions
--- a/module/CLI/test/Command/ShortUrl/CreateShortUrlCommandTest.php
+++ b/module/CLI/test/Command/ShortUrl/CreateShortUrlCommandTest.php
@@ -0,0 +1,140 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;
+
+use PHPUnit\Framework\Assert;
+use PHPUnit\Framework\TestCase;
+use Prophecy\Argument;
+use Prophecy\Prophecy\ObjectProphecy;
+use Shlinkio\Shlink\CLI\Command\ShortUrl\CreateShortUrlCommand;
+use Shlinkio\Shlink\CLI\Util\ExitCodes;
+use Shlinkio\Shlink\Core\Entity\ShortUrl;
+use Shlinkio\Shlink\Core\Exception\InvalidUrlException;
+use Shlinkio\Shlink\Core\Exception\NonUniqueSlugException;
+use Shlinkio\Shlink\Core\Model\ShortUrlMeta;
+use Shlinkio\Shlink\Core\Service\UrlShortener;
+use Shlinkio\Shlink\Core\ShortUrl\Helper\ShortUrlStringifierInterface;
+use ShlinkioTest\Shlink\CLI\CliTestUtilsTrait;
+use Symfony\Component\Console\Tester\CommandTester;
+
+class CreateShortUrlCommandTest extends TestCase
+{
+    use CliTestUtilsTrait;
+
+    private CommandTester $commandTester;
+    private ObjectProphecy $urlShortener;
+    private ObjectProphecy $stringifier;
+
+    public function setUp(): void
+    {
+        $this->urlShortener = $this->prophesize(UrlShortener::class);
+        $this->stringifier = $this->prophesize(ShortUrlStringifierInterface::class);
+        $this->stringifier->stringify(Argument::type(ShortUrl::class))->willReturn('');
+
+        $command = new CreateShortUrlCommand($this->urlShortener->reveal(), $this->stringifier->reveal(), 5);
+        $this->commandTester = $this->testerForCommand($command);
+    }
+
+    /** @test */
+    public function properShortCodeIsCreatedIfLongUrlIsCorrect(): void
+    {
+        $shortUrl = ShortUrl::createEmpty();
+        $urlToShortCode = $this->urlShortener->shorten(Argument::cetera())->willReturn($shortUrl);
+        $stringify = $this->stringifier->stringify($shortUrl)->willReturn('stringified_short_url');
+
+        $this->commandTester->execute([
+            'longUrl' => 'http://domain.com/foo/bar',
+            '--max-visits' => '3',
+        ]);
+        $output = $this->commandTester->getDisplay();
+
+        self::assertEquals(ExitCodes::EXIT_SUCCESS, $this->commandTester->getStatusCode());
+        self::assertStringContainsString('stringified_short_url', $output);
+        $urlToShortCode->shouldHaveBeenCalledOnce();
+        $stringify->shouldHaveBeenCalledOnce();
+    }
+
+    /** @test */
+    public function exceptionWhileParsingLongUrlOutputsError(): void
+    {
+        $url = 'http://domain.com/invalid';
+        $this->urlShortener->shorten(Argument::cetera())->willThrow(InvalidUrlException::fromUrl($url))
+                                                               ->shouldBeCalledOnce();
+
+        $this->commandTester->execute(['longUrl' => $url]);
+        $output = $this->commandTester->getDisplay();
+
+        self::assertEquals(ExitCodes::EXIT_FAILURE, $this->commandTester->getStatusCode());
+        self::assertStringContainsString('Provided URL http://domain.com/invalid is invalid.', $output);
+    }
+
+    /** @test */
+    public function providingNonUniqueSlugOutputsError(): void
+    {
+        $urlToShortCode = $this->urlShortener->shorten(Argument::cetera())->willThrow(
+            NonUniqueSlugException::fromSlug('my-slug'),
+        );
+
+        $this->commandTester->execute(['longUrl' => 'http://domain.com/invalid', '--custom-slug' => 'my-slug']);
+        $output = $this->commandTester->getDisplay();
+
+        self::assertEquals(ExitCodes::EXIT_FAILURE, $this->commandTester->getStatusCode());
+        self::assertStringContainsString('Provided slug "my-slug" is already in use', $output);
+        $urlToShortCode->shouldHaveBeenCalledOnce();
+    }
+
+    /** @test */
+    public function properlyProcessesProvidedTags(): void
+    {
+        $shortUrl = ShortUrl::createEmpty();
+        $urlToShortCode = $this->urlShortener->shorten(
+            Argument::that(function (ShortUrlMeta $meta) {
+                $tags = $meta->getTags();
+                Assert::assertEquals(['foo', 'bar', 'baz', 'boo', 'zar'], $tags);
+                return true;
+            }),
+        )->willReturn($shortUrl);
+        $stringify = $this->stringifier->stringify($shortUrl)->willReturn('stringified_short_url');
+
+        $this->commandTester->execute([
+            'longUrl' => 'http://domain.com/foo/bar',
+            '--tags' => ['foo,bar', 'baz', 'boo,zar,baz'],
+        ]);
+        $output = $this->commandTester->getDisplay();
+
+        self::assertEquals(ExitCodes::EXIT_SUCCESS, $this->commandTester->getStatusCode());
+        self::assertStringContainsString('stringified_short_url', $output);
+        $urlToShortCode->shouldHaveBeenCalledOnce();
+        $stringify->shouldHaveBeenCalledOnce();
+    }
+
+    /**
+     * @test
+     * @dataProvider provideFlags
+     */
+    public function urlValidationHasExpectedValueBasedOnProvidedTags(array $options, ?bool $expectedValidateUrl): void
+    {
+        $shortUrl = ShortUrl::createEmpty();
+        $urlToShortCode = $this->urlShortener->shorten(
+            Argument::that(function (ShortUrlMeta $meta) use ($expectedValidateUrl) {
+                Assert::assertEquals($expectedValidateUrl, $meta->doValidateUrl());
+                return $meta;
+            }),
+        )->willReturn($shortUrl);
+
+        $options['longUrl'] = 'http://domain.com/foo/bar';
+        $this->commandTester->execute($options);
+
+        $urlToShortCode->shouldHaveBeenCalledOnce();
+    }
+
+    public function provideFlags(): iterable
+    {
+        yield 'no flags' => [[], null];
+        yield 'no-validate-url only' => [['--no-validate-url' => true], false];
+        yield 'validate-url' => [['--validate-url' => true], true];
+        yield 'both flags' => [['--validate-url' => true, '--no-validate-url' => true], false];
+    }
+}